Skip to content

Commit b9f50da

Browse files
committed
Adds docstring and tweaks changelog
Per feedback by @Archmonger
1 parent 60345a5 commit b9f50da

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

docs/source/about/changelog.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ Unreleased
7070
**Fixed**
7171

7272
- :pull:`1239` - Fixed a bug where script elements would not render to the DOM as plain text.
73-
- :pull:`1271` - Fixed bug where JavaScript components were unable to obtain the ``key`` attribute provided within ReactPy.
73+
- :pull:`1271` - Fixed a bug where the ``key`` property provided via server-side ReactPy code was failing to propagate to the front-end JavaScript component.
7474
- :pull:`1254` - Fixed a bug where ``RuntimeError("Hook stack is in an invalid state")`` errors would be provided when using a webserver that reuses threads.
7575

7676
v1.1.0

tests/test_web/test_module.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,13 @@ async def test_imported_components_can_render_children(display: DisplayFixture):
209209

210210

211211
async def test_keys_properly_propagated(display: DisplayFixture):
212+
""" Addresses issue #1271
213+
The "key" property was being lost in its propagation from
214+
the server-side ReactPy definition to the front-end JavaScript.
215+
This is a critical issue for the proper functionality of
216+
certain components, such as the GridLayout from
217+
react-grid-layout.
218+
"""
212219
module = reactpy.web.module_from_file(
213220
"keys-properly-propagated", JS_FIXTURES_DIR / "keys-properly-propagated.js"
214221
)

0 commit comments

Comments
 (0)