From 217c129f655e4f3e256f588eed1bb670b884c3e9 Mon Sep 17 00:00:00 2001 From: Santiago Bartesaghi Date: Fri, 26 Dec 2025 09:58:00 -0300 Subject: [PATCH 1/2] Fix CI: connection_pool version --- Appraisals | 53 +++++++++++++------ ...tive_support_7_0_redis_cache_store.gemfile | 1 + ...tive_support_7_1_redis_cache_store.gemfile | 1 + ...tive_support_7_2_redis_cache_store.gemfile | 1 + ...tive_support_8_0_redis_cache_store.gemfile | 1 + ...tive_support_8_1_redis_cache_store.gemfile | 1 + gemfiles/dalli3.gemfile | 1 + gemfiles/redis_4.gemfile | 1 + gemfiles/redis_5.gemfile | 1 + gemfiles/redis_store.gemfile | 1 + 10 files changed, 46 insertions(+), 16 deletions(-) diff --git a/Appraisals b/Appraisals index 696ba67f..ad61248e 100644 --- a/Appraisals +++ b/Appraisals @@ -8,36 +8,45 @@ appraise "rack_2" do gem "rack", "~> 2.0" end -appraise 'rails_8-1' do - gem 'railties', '~> 8.1.0' +appraise "rails_8-1" do + gem "railties", "~> 8.1.0" end -appraise 'rails_8-0' do - gem 'railties', '~> 8.0.0' +appraise "rails_8-0" do + gem "railties", "~> 8.0.0" end -appraise 'rails_7-2' do - gem 'railties', '~> 7.2.0' +appraise "rails_7-2" do + gem "railties", "~> 7.2.0" end -appraise 'rails_7-1' do - gem 'railties', '~> 7.1.0' +appraise "rails_7-1" do + gem "railties", "~> 7.1.0" end -appraise 'rails_7-0' do - gem 'railties', '~> 7.0.0' +appraise "rails_7-0" do + gem "railties", "~> 7.0.0" end -appraise 'dalli3' do - gem 'dalli', '~> 3.0' +appraise "dalli3" do + # Direct version requirement on connection_pool + # can be removed once https://github.com/petergoldstein/dalli/pull/1049 is fixed and released + gem "connection_pool", "~> 2.5" + gem "dalli", "~> 3.0" end -appraise 'redis_5' do - gem 'redis', '~> 5.0' +appraise "redis_5" do + # Direct version requirement on connection_pool + # can be removed once https://github.com/rails/rails#56291 is fixed and released + gem "connection_pool", "~> 2.5" + gem "redis", "~> 5.0" end -appraise 'redis_4' do - gem 'redis', '~> 4.0' +appraise "redis_4" do + # Direct version requirement on connection_pool + # can be removed once https://github.com/rails/rails#56291 is fixed and released + gem "connection_pool", "~> 2.5" + gem "redis", "~> 4.0" end appraise "connection_pool_dalli" do @@ -47,6 +56,9 @@ end appraise "active_support_8-1_redis_cache_store" do gem "activesupport", "~> 8.1.0" + # Direct version requirement on connection_pool + # can be removed once https://github.com/rails/rails#56291 is fixed and released + gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" end @@ -58,6 +70,9 @@ end appraise "active_support_8-0_redis_cache_store" do gem "activesupport", "~> 8.0.0" + # Direct version requirement on connection_pool + # can be removed once https://github.com/rails/rails#56291 is fixed and released + gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" end @@ -69,6 +84,7 @@ end appraise "active_support_7-2_redis_cache_store" do gem "activesupport", "~> 7.2.0" + gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" end @@ -80,6 +96,7 @@ end appraise "active_support_7-1_redis_cache_store" do gem "activesupport", "~> 7.1.0" + gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" end @@ -91,6 +108,7 @@ end appraise "active_support_7-0_redis_cache_store" do gem "activesupport", "~> 7.0.0" + gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" end @@ -101,5 +119,8 @@ appraise "active_support_7-0_redis_cache_store_pooled" do end appraise "redis_store" do + # Direct version requirement on connection_pool + # can be removed once https://github.com/rails/rails#56291 is fixed and released + gem "connection_pool", "~> 2.5" gem "redis-store", "~> 1.5" end diff --git a/gemfiles/active_support_7_0_redis_cache_store.gemfile b/gemfiles/active_support_7_0_redis_cache_store.gemfile index a94cfe88..f4e44cb7 100644 --- a/gemfiles/active_support_7_0_redis_cache_store.gemfile +++ b/gemfiles/active_support_7_0_redis_cache_store.gemfile @@ -3,6 +3,7 @@ source "https://rubygems.org" gem "activesupport", "~> 7.0.0" +gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" group :maintenance, optional: true do diff --git a/gemfiles/active_support_7_1_redis_cache_store.gemfile b/gemfiles/active_support_7_1_redis_cache_store.gemfile index a0602ba5..f0b0ae68 100644 --- a/gemfiles/active_support_7_1_redis_cache_store.gemfile +++ b/gemfiles/active_support_7_1_redis_cache_store.gemfile @@ -3,6 +3,7 @@ source "https://rubygems.org" gem "activesupport", "~> 7.1.0" +gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" group :maintenance, optional: true do diff --git a/gemfiles/active_support_7_2_redis_cache_store.gemfile b/gemfiles/active_support_7_2_redis_cache_store.gemfile index 3c433092..f0ec3a90 100644 --- a/gemfiles/active_support_7_2_redis_cache_store.gemfile +++ b/gemfiles/active_support_7_2_redis_cache_store.gemfile @@ -3,6 +3,7 @@ source "https://rubygems.org" gem "activesupport", "~> 7.2.0" +gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" group :maintenance, optional: true do diff --git a/gemfiles/active_support_8_0_redis_cache_store.gemfile b/gemfiles/active_support_8_0_redis_cache_store.gemfile index b813cb38..e192fda3 100644 --- a/gemfiles/active_support_8_0_redis_cache_store.gemfile +++ b/gemfiles/active_support_8_0_redis_cache_store.gemfile @@ -3,6 +3,7 @@ source "https://rubygems.org" gem "activesupport", "~> 8.0.0" +gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" group :maintenance, optional: true do diff --git a/gemfiles/active_support_8_1_redis_cache_store.gemfile b/gemfiles/active_support_8_1_redis_cache_store.gemfile index 57e0ff21..1dd14ed8 100644 --- a/gemfiles/active_support_8_1_redis_cache_store.gemfile +++ b/gemfiles/active_support_8_1_redis_cache_store.gemfile @@ -3,6 +3,7 @@ source "https://rubygems.org" gem "activesupport", "~> 8.1.0" +gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" group :maintenance, optional: true do diff --git a/gemfiles/dalli3.gemfile b/gemfiles/dalli3.gemfile index 3873dedf..72c4d5a4 100644 --- a/gemfiles/dalli3.gemfile +++ b/gemfiles/dalli3.gemfile @@ -2,6 +2,7 @@ source "https://rubygems.org" +gem "connection_pool", "~> 2.5" gem "dalli", "~> 3.0" group :maintenance, optional: true do diff --git a/gemfiles/redis_4.gemfile b/gemfiles/redis_4.gemfile index e8b82f16..f771437e 100644 --- a/gemfiles/redis_4.gemfile +++ b/gemfiles/redis_4.gemfile @@ -2,6 +2,7 @@ source "https://rubygems.org" +gem "connection_pool", "~> 2.5" gem "redis", "~> 4.0" group :maintenance, optional: true do diff --git a/gemfiles/redis_5.gemfile b/gemfiles/redis_5.gemfile index fc9b4655..46abad15 100644 --- a/gemfiles/redis_5.gemfile +++ b/gemfiles/redis_5.gemfile @@ -2,6 +2,7 @@ source "https://rubygems.org" +gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" group :maintenance, optional: true do diff --git a/gemfiles/redis_store.gemfile b/gemfiles/redis_store.gemfile index e32d1e9e..63d68b22 100644 --- a/gemfiles/redis_store.gemfile +++ b/gemfiles/redis_store.gemfile @@ -2,6 +2,7 @@ source "https://rubygems.org" +gem "connection_pool", "~> 2.5" gem "redis-store", "~> 1.5" group :maintenance, optional: true do From 2b828af1eae037d7d20951575e8eeb01d19e6073 Mon Sep 17 00:00:00 2001 From: Santiago Bartesaghi Date: Mon, 29 Dec 2025 15:48:13 -0300 Subject: [PATCH 2/2] Try more aggressive approach --- .github/workflows/build.yml | 24 -------- Appraisals | 56 ------------------- ...tive_support_7_0_redis_cache_store.gemfile | 1 - ...pport_7_0_redis_cache_store_pooled.gemfile | 14 ----- ...tive_support_7_1_redis_cache_store.gemfile | 1 - ...pport_7_1_redis_cache_store_pooled.gemfile | 14 ----- ...tive_support_7_2_redis_cache_store.gemfile | 1 - ...pport_7_2_redis_cache_store_pooled.gemfile | 14 ----- ...tive_support_8_0_redis_cache_store.gemfile | 1 - ...pport_8_0_redis_cache_store_pooled.gemfile | 14 ----- ...tive_support_8_1_redis_cache_store.gemfile | 1 - ...pport_8_1_redis_cache_store_pooled.gemfile | 14 ----- gemfiles/connection_pool_dalli.gemfile | 13 ----- gemfiles/dalli3.gemfile | 1 - gemfiles/redis_4.gemfile | 1 - gemfiles/redis_5.gemfile | 1 - gemfiles/redis_store.gemfile | 1 - rack-attack.gemspec | 3 + 18 files changed, 3 insertions(+), 172 deletions(-) delete mode 100644 gemfiles/active_support_7_0_redis_cache_store_pooled.gemfile delete mode 100644 gemfiles/active_support_7_1_redis_cache_store_pooled.gemfile delete mode 100644 gemfiles/active_support_7_2_redis_cache_store_pooled.gemfile delete mode 100644 gemfiles/active_support_8_0_redis_cache_store_pooled.gemfile delete mode 100644 gemfiles/active_support_8_1_redis_cache_store_pooled.gemfile delete mode 100644 gemfiles/connection_pool_dalli.gemfile diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 003db772..6e4eee24 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -35,25 +35,17 @@ jobs: - dalli3 - redis_5 - redis_4 - - connection_pool_dalli - active_support_8_1_redis_cache_store - - active_support_8_1_redis_cache_store_pooled - active_support_8_0_redis_cache_store - - active_support_8_0_redis_cache_store_pooled - active_support_7_2_redis_cache_store - - active_support_7_2_redis_cache_store_pooled - active_support_7_1_redis_cache_store - - active_support_7_1_redis_cache_store_pooled - active_support_7_0_redis_cache_store - - active_support_7_0_redis_cache_store_pooled - redis_store exclude: - gemfile: rails_7_0 ruby: '3.4' - gemfile: active_support_7_0_redis_cache_store ruby: '3.4' - - gemfile: active_support_7_0_redis_cache_store_pooled - ruby: '3.4' - gemfile: rails_7_2 ruby: '3.0' - gemfile: rails_7_2 @@ -62,10 +54,6 @@ jobs: ruby: '3.0' - gemfile: active_support_7_2_redis_cache_store ruby: '2.7' - - gemfile: active_support_7_2_redis_cache_store_pooled - ruby: '3.0' - - gemfile: active_support_7_2_redis_cache_store_pooled - ruby: '2.7' - gemfile: rails_8_0 ruby: '3.1' - gemfile: rails_8_0 @@ -78,12 +66,6 @@ jobs: ruby: '3.0' - gemfile: active_support_8_0_redis_cache_store ruby: '2.7' - - gemfile: active_support_8_0_redis_cache_store_pooled - ruby: '3.1' - - gemfile: active_support_8_0_redis_cache_store_pooled - ruby: '3.0' - - gemfile: active_support_8_0_redis_cache_store_pooled - ruby: '2.7' - gemfile: rails_8_1 ruby: '3.1' - gemfile: rails_8_1 @@ -96,12 +78,6 @@ jobs: ruby: '3.0' - gemfile: active_support_8_1_redis_cache_store ruby: '2.7' - - gemfile: active_support_8_1_redis_cache_store_pooled - ruby: '3.1' - - gemfile: active_support_8_1_redis_cache_store_pooled - ruby: '3.0' - - gemfile: active_support_8_1_redis_cache_store_pooled - ruby: '2.7' env: BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile steps: diff --git a/Appraisals b/Appraisals index ad61248e..9ca0281a 100644 --- a/Appraisals +++ b/Appraisals @@ -29,98 +29,42 @@ appraise "rails_7-0" do end appraise "dalli3" do - # Direct version requirement on connection_pool - # can be removed once https://github.com/petergoldstein/dalli/pull/1049 is fixed and released - gem "connection_pool", "~> 2.5" gem "dalli", "~> 3.0" end appraise "redis_5" do - # Direct version requirement on connection_pool - # can be removed once https://github.com/rails/rails#56291 is fixed and released - gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" end appraise "redis_4" do - # Direct version requirement on connection_pool - # can be removed once https://github.com/rails/rails#56291 is fixed and released - gem "connection_pool", "~> 2.5" gem "redis", "~> 4.0" end -appraise "connection_pool_dalli" do - gem "connection_pool", "~> 2.2" - gem "dalli", "~> 3.0" -end - appraise "active_support_8-1_redis_cache_store" do gem "activesupport", "~> 8.1.0" - # Direct version requirement on connection_pool - # can be removed once https://github.com/rails/rails#56291 is fixed and released - gem "connection_pool", "~> 2.5" - gem "redis", "~> 5.0" -end - -appraise "active_support_8-1_redis_cache_store_pooled" do - gem "activesupport", "~> 8.1.0" - gem "connection_pool", "~> 2.2" gem "redis", "~> 5.0" end appraise "active_support_8-0_redis_cache_store" do gem "activesupport", "~> 8.0.0" - # Direct version requirement on connection_pool - # can be removed once https://github.com/rails/rails#56291 is fixed and released - gem "connection_pool", "~> 2.5" - gem "redis", "~> 5.0" -end - -appraise "active_support_8-0_redis_cache_store_pooled" do - gem "activesupport", "~> 8.0.0" - gem "connection_pool", "~> 2.2" gem "redis", "~> 5.0" end appraise "active_support_7-2_redis_cache_store" do gem "activesupport", "~> 7.2.0" - gem "connection_pool", "~> 2.5" - gem "redis", "~> 5.0" -end - -appraise "active_support_7-2_redis_cache_store_pooled" do - gem "activesupport", "~> 7.2.0" - gem "connection_pool", "~> 2.2" gem "redis", "~> 5.0" end appraise "active_support_7-1_redis_cache_store" do gem "activesupport", "~> 7.1.0" - gem "connection_pool", "~> 2.5" - gem "redis", "~> 5.0" -end - -appraise "active_support_7-1_redis_cache_store_pooled" do - gem "activesupport", "~> 7.1.0" - gem "connection_pool", "~> 2.2" gem "redis", "~> 5.0" end appraise "active_support_7-0_redis_cache_store" do gem "activesupport", "~> 7.0.0" - gem "connection_pool", "~> 2.5" - gem "redis", "~> 5.0" -end - -appraise "active_support_7-0_redis_cache_store_pooled" do - gem "activesupport", "~> 7.0.0" - gem "connection_pool", "~> 2.2" gem "redis", "~> 5.0" end appraise "redis_store" do - # Direct version requirement on connection_pool - # can be removed once https://github.com/rails/rails#56291 is fixed and released - gem "connection_pool", "~> 2.5" gem "redis-store", "~> 1.5" end diff --git a/gemfiles/active_support_7_0_redis_cache_store.gemfile b/gemfiles/active_support_7_0_redis_cache_store.gemfile index f4e44cb7..a94cfe88 100644 --- a/gemfiles/active_support_7_0_redis_cache_store.gemfile +++ b/gemfiles/active_support_7_0_redis_cache_store.gemfile @@ -3,7 +3,6 @@ source "https://rubygems.org" gem "activesupport", "~> 7.0.0" -gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" group :maintenance, optional: true do diff --git a/gemfiles/active_support_7_0_redis_cache_store_pooled.gemfile b/gemfiles/active_support_7_0_redis_cache_store_pooled.gemfile deleted file mode 100644 index bd2a6e71..00000000 --- a/gemfiles/active_support_7_0_redis_cache_store_pooled.gemfile +++ /dev/null @@ -1,14 +0,0 @@ -# This file was generated by Appraisal - -source "https://rubygems.org" - -gem "activesupport", "~> 7.0.0" -gem "connection_pool", "~> 2.2" -gem "redis", "~> 5.0" - -group :maintenance, optional: true do - gem "bake" - gem "bake-gem" -end - -gemspec path: "../" diff --git a/gemfiles/active_support_7_1_redis_cache_store.gemfile b/gemfiles/active_support_7_1_redis_cache_store.gemfile index f0b0ae68..a0602ba5 100644 --- a/gemfiles/active_support_7_1_redis_cache_store.gemfile +++ b/gemfiles/active_support_7_1_redis_cache_store.gemfile @@ -3,7 +3,6 @@ source "https://rubygems.org" gem "activesupport", "~> 7.1.0" -gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" group :maintenance, optional: true do diff --git a/gemfiles/active_support_7_1_redis_cache_store_pooled.gemfile b/gemfiles/active_support_7_1_redis_cache_store_pooled.gemfile deleted file mode 100644 index ae2d6d96..00000000 --- a/gemfiles/active_support_7_1_redis_cache_store_pooled.gemfile +++ /dev/null @@ -1,14 +0,0 @@ -# This file was generated by Appraisal - -source "https://rubygems.org" - -gem "activesupport", "~> 7.1.0" -gem "connection_pool", "~> 2.2" -gem "redis", "~> 5.0" - -group :maintenance, optional: true do - gem "bake" - gem "bake-gem" -end - -gemspec path: "../" diff --git a/gemfiles/active_support_7_2_redis_cache_store.gemfile b/gemfiles/active_support_7_2_redis_cache_store.gemfile index f0ec3a90..3c433092 100644 --- a/gemfiles/active_support_7_2_redis_cache_store.gemfile +++ b/gemfiles/active_support_7_2_redis_cache_store.gemfile @@ -3,7 +3,6 @@ source "https://rubygems.org" gem "activesupport", "~> 7.2.0" -gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" group :maintenance, optional: true do diff --git a/gemfiles/active_support_7_2_redis_cache_store_pooled.gemfile b/gemfiles/active_support_7_2_redis_cache_store_pooled.gemfile deleted file mode 100644 index 3b441b0b..00000000 --- a/gemfiles/active_support_7_2_redis_cache_store_pooled.gemfile +++ /dev/null @@ -1,14 +0,0 @@ -# This file was generated by Appraisal - -source "https://rubygems.org" - -gem "activesupport", "~> 7.2.0" -gem "connection_pool", "~> 2.2" -gem "redis", "~> 5.0" - -group :maintenance, optional: true do - gem "bake" - gem "bake-gem" -end - -gemspec path: "../" diff --git a/gemfiles/active_support_8_0_redis_cache_store.gemfile b/gemfiles/active_support_8_0_redis_cache_store.gemfile index e192fda3..b813cb38 100644 --- a/gemfiles/active_support_8_0_redis_cache_store.gemfile +++ b/gemfiles/active_support_8_0_redis_cache_store.gemfile @@ -3,7 +3,6 @@ source "https://rubygems.org" gem "activesupport", "~> 8.0.0" -gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" group :maintenance, optional: true do diff --git a/gemfiles/active_support_8_0_redis_cache_store_pooled.gemfile b/gemfiles/active_support_8_0_redis_cache_store_pooled.gemfile deleted file mode 100644 index 4d80d168..00000000 --- a/gemfiles/active_support_8_0_redis_cache_store_pooled.gemfile +++ /dev/null @@ -1,14 +0,0 @@ -# This file was generated by Appraisal - -source "https://rubygems.org" - -gem "activesupport", "~> 8.0.0" -gem "connection_pool", "~> 2.2" -gem "redis", "~> 5.0" - -group :maintenance, optional: true do - gem "bake" - gem "bake-gem" -end - -gemspec path: "../" diff --git a/gemfiles/active_support_8_1_redis_cache_store.gemfile b/gemfiles/active_support_8_1_redis_cache_store.gemfile index 1dd14ed8..57e0ff21 100644 --- a/gemfiles/active_support_8_1_redis_cache_store.gemfile +++ b/gemfiles/active_support_8_1_redis_cache_store.gemfile @@ -3,7 +3,6 @@ source "https://rubygems.org" gem "activesupport", "~> 8.1.0" -gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" group :maintenance, optional: true do diff --git a/gemfiles/active_support_8_1_redis_cache_store_pooled.gemfile b/gemfiles/active_support_8_1_redis_cache_store_pooled.gemfile deleted file mode 100644 index 6e49595b..00000000 --- a/gemfiles/active_support_8_1_redis_cache_store_pooled.gemfile +++ /dev/null @@ -1,14 +0,0 @@ -# This file was generated by Appraisal - -source "https://rubygems.org" - -gem "activesupport", "~> 8.1.0" -gem "connection_pool", "~> 2.2" -gem "redis", "~> 5.0" - -group :maintenance, optional: true do - gem "bake" - gem "bake-gem" -end - -gemspec path: "../" diff --git a/gemfiles/connection_pool_dalli.gemfile b/gemfiles/connection_pool_dalli.gemfile deleted file mode 100644 index f84eb52e..00000000 --- a/gemfiles/connection_pool_dalli.gemfile +++ /dev/null @@ -1,13 +0,0 @@ -# This file was generated by Appraisal - -source "https://rubygems.org" - -gem "connection_pool", "~> 2.2" -gem "dalli", "~> 3.0" - -group :maintenance, optional: true do - gem "bake" - gem "bake-gem" -end - -gemspec path: "../" diff --git a/gemfiles/dalli3.gemfile b/gemfiles/dalli3.gemfile index 72c4d5a4..3873dedf 100644 --- a/gemfiles/dalli3.gemfile +++ b/gemfiles/dalli3.gemfile @@ -2,7 +2,6 @@ source "https://rubygems.org" -gem "connection_pool", "~> 2.5" gem "dalli", "~> 3.0" group :maintenance, optional: true do diff --git a/gemfiles/redis_4.gemfile b/gemfiles/redis_4.gemfile index f771437e..e8b82f16 100644 --- a/gemfiles/redis_4.gemfile +++ b/gemfiles/redis_4.gemfile @@ -2,7 +2,6 @@ source "https://rubygems.org" -gem "connection_pool", "~> 2.5" gem "redis", "~> 4.0" group :maintenance, optional: true do diff --git a/gemfiles/redis_5.gemfile b/gemfiles/redis_5.gemfile index 46abad15..fc9b4655 100644 --- a/gemfiles/redis_5.gemfile +++ b/gemfiles/redis_5.gemfile @@ -2,7 +2,6 @@ source "https://rubygems.org" -gem "connection_pool", "~> 2.5" gem "redis", "~> 5.0" group :maintenance, optional: true do diff --git a/gemfiles/redis_store.gemfile b/gemfiles/redis_store.gemfile index 63d68b22..e32d1e9e 100644 --- a/gemfiles/redis_store.gemfile +++ b/gemfiles/redis_store.gemfile @@ -2,7 +2,6 @@ source "https://rubygems.org" -gem "connection_pool", "~> 2.5" gem "redis-store", "~> 1.5" group :maintenance, optional: true do diff --git a/rack-attack.gemspec b/rack-attack.gemspec index 41cc7a8f..fe2e1566 100644 --- a/rack-attack.gemspec +++ b/rack-attack.gemspec @@ -46,4 +46,7 @@ Gem::Specification.new do |s| end s.add_development_dependency "activesupport" + # Fix activesupport Direct version requirement on connection_pool + # can be removed once https://github.com/rails/rails/issues/56291 is ixed and released + s.add_development_dependency "connection_pool", "~> 2.5" end