Respect tramp connection in the proper environment check.

Save pythonic-tramp-connection within :connection process property
rather default-directory.  This will not require to pass
from-directory argument into pythonic-proper-environment-p predicate.

Author: proofit404

pythonic.el

@@ -209,16 +209,17 @@ process flag."
       (process-put process
                    'pythonic
                    (list
-                    :default-directory default-directory
-                    :environment python-shell-process-environment
+                    :connection (pythonic-tramp-connection)
+                    :pythonpath (pythonic-get-pythonpath)
                     :path (pythonic-get-path)
-                    :pythonpath (pythonic-get-pythonpath)))
+                    :environment python-shell-process-environment))
       process)))
 
 (defun pythonic-proper-environment-p (process)
   "Determine if python environment has been changed since PROCESS was started."
   (--if-let (process-get process 'pythonic)
       (and
+       (equal (plist-get it :connection) (pythonic-tramp-connection))
        (equal (plist-get it :pythonpath) (pythonic-get-pythonpath))
        (equal (plist-get it :path) (pythonic-get-path))
        (equal (plist-get it :environment) python-shell-process-environment))

test/pythonic-test.el

@@ -365,15 +365,19 @@ Respect remote PYTHONPATH value."
     (setq tramp-current-connection)
     (sleep-for 0.5)))
 
-(ert-deftest test-start-pythonic-default-directory-property ()
-  "Set `pythonic-default-directory' result as `default-directory' process property."
-  (let ((default-directorys "~"))
-    (should (equal (f-full "~")
-                   (plist-get
-                    (process-get
-                     (start-pythonic :process "out" :args '("-V"))
-                     'pythonic)
-                    :default-directory)))))
+(ert-deftest test-start-pythonic-connection-property ()
+  "Set `pythonic-tramp-connection' result as `connection' process property."
+  (unwind-protect
+      (let ((python-shell-interpreter "/ssh:test@localhost:/path/to/the/python"))
+        (should (equal "/ssh:test@localhost:"
+                       (plist-get
+                        (process-get
+                         (start-pythonic :process "out" :args '("-V"))
+                         'pythonic)
+                        :connection))))
+    (kill-buffer "*tramp/ssh test@localhost*")
+    (setq tramp-current-connection)
+    (sleep-for 0.5)))
 
 (ert-deftest test-start-pythonic-environment-property ()
   "Set `python-shell-process-environment' as `environment' process property."
@@ -416,6 +420,16 @@ change since process was start."
          (python-shell-process-environment '("TEST=t")))
     (should-not (pythonic-proper-environment-p process))))
 
+(ert-deftest test-pythonic-proper-environment-p-change-host ()
+  "`pythonic-proper-environment-p' is null if tramp host was changed."
+  ;; `unwind-protect' block is unnecessary here because non of tramp
+  ;; connection will be opened below.  First process starts locally,
+  ;; proper environment check will stop at connection strings
+  ;; comparison, non of remote PATH or PYTHONPATH checks will be made.
+  (let* ((process (start-pythonic :process "out" :args '("-V")))
+         (python-shell-interpreter "/ssh:test@localhost:/path/to/the/python"))
+    (should-not (pythonic-proper-environment-p process))))
+
 ;;; Activate/deactivate environment.
 
 (ert-deftest test-pythonic-activate ()