Skip to content

Commit 782fa23

Browse files
committed
Remove manual step to edit pre-release page
1 parent f408a38 commit 782fa23

File tree

2 files changed

+0
-58
lines changed

2 files changed

+0
-58
lines changed

run_release.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1110,23 +1110,6 @@ def purge_the_cdn(db: ReleaseShelf) -> None:
11101110
raise RuntimeError("Failed to purge the python.org/downloads CDN")
11111111

11121112

1113-
def modify_the_prereleases_page(db: ReleaseShelf) -> None:
1114-
if db["release"].is_final:
1115-
if not ask_question(
1116-
"Have you already removed the release from https://www.python.org/download/pre-releases/ ?"
1117-
):
1118-
raise ReleaseException(
1119-
"The release has not been removed from the pre-releases page"
1120-
)
1121-
else:
1122-
if not ask_question(
1123-
"Have you already added the release to https://www.python.org/download/pre-releases/ ?"
1124-
):
1125-
raise ReleaseException(
1126-
"The release has not been added to the pre-releases page"
1127-
)
1128-
1129-
11301113
def modify_the_docs_by_version_page(db: ReleaseShelf) -> None:
11311114
if db["release"].is_final:
11321115
version = db["release"]
@@ -1478,7 +1461,6 @@ def _api_key(api_key: str) -> str:
14781461
Task(remove_temporary_branch, "Removing temporary release branch"),
14791462
Task(run_add_to_python_dot_org, "Add files to python.org download page"),
14801463
Task(purge_the_cdn, "Purge the CDN of python.org/downloads"),
1481-
Task(modify_the_prereleases_page, "Modify the pre-release page"),
14821464
Task(modify_the_docs_by_version_page, "Update docs by version page"),
14831465
Task(announce_release, "Announce the release"),
14841466
]

tests/test_run_release.py

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -147,46 +147,6 @@ def test_check_doc_unreleased_version_waived(monkeypatch, tmp_path: Path) -> Non
147147
run_release.check_doc_unreleased_version(cast(ReleaseShelf, db))
148148

149149

150-
@pytest.mark.parametrize(
151-
["tag", "expected"],
152-
[
153-
("3.14.0a7", "Have you already added the release to "),
154-
("3.13.3", "Have you already removed the release from "),
155-
],
156-
)
157-
def test_modify_the_prerelease_page_yes(
158-
capsys, monkeypatch, tag: str, expected: str
159-
) -> None:
160-
# Arrange
161-
db = {"release": Tag(tag)}
162-
163-
# Act
164-
with fake_answers(monkeypatch, ["yes"]):
165-
run_release.modify_the_prereleases_page(cast(ReleaseShelf, db))
166-
167-
# Assert
168-
assert expected in capsys.readouterr().out
169-
170-
171-
@pytest.mark.parametrize(
172-
["tag", "expected"],
173-
[
174-
("3.14.0a7", "The release has not been added to the pre-releases page"),
175-
("3.13.3", "The release has not been removed from the pre-releases page"),
176-
],
177-
)
178-
def test_modify_the_prerelease_page_no(monkeypatch, tag: str, expected: str) -> None:
179-
# Arrange
180-
db = {"release": Tag(tag)}
181-
182-
# Act
183-
with (
184-
fake_answers(monkeypatch, ["no"]),
185-
pytest.raises(run_release.ReleaseException, match=expected),
186-
):
187-
run_release.modify_the_prereleases_page(cast(ReleaseShelf, db))
188-
189-
190150
def test_modify_the_docs_by_version_page_prerelease(capsys) -> None:
191151
# Arrange
192152
db = {"release": Tag("3.14.0a7")}

0 commit comments

Comments
 (0)