From 6c19a250cceca316b5876e3466392ed833c6e588 Mon Sep 17 00:00:00 2001
From: Seth Michael Larson <seth@python.org>
Date: Thu, 5 Mar 2026 11:15:32 -0600
Subject: [PATCH] Address Copilot review of format_html() functions

---
 apps/companies/tests.py | 4 ++++
 apps/sponsors/admin.py  | 8 ++++----
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/apps/companies/tests.py b/apps/companies/tests.py
index 8f94a525d..3eb9e6afb 100644
--- a/apps/companies/tests.py
+++ b/apps/companies/tests.py
@@ -10,3 +10,7 @@ def test_render_email(self):
             render_email("firstname.lastname@domain.com"),
             "firstname<span>.</span>lastname<span>@</span>domain<span>.</span>com",
         )
+        self.assertEqual(
+            render_email('"escape.>me"@domain.com'),
+            "&quot;escape<span>.</span>&gt;me&quot;<span>@</span>domain<span>.</span>com",
+        )
diff --git a/apps/sponsors/admin.py b/apps/sponsors/admin.py
index 28326415a..ff20acee8 100644
--- a/apps/sponsors/admin.py
+++ b/apps/sponsors/admin.py
@@ -807,7 +807,7 @@ def get_custom_benefits_added_by_user(self, obj):
         if not benefits:
             return "---"
 
-        return format_html_join("", "<p>{}</p>", benefits)
+        return format_html_join("", "<p>{}</p>", [(benefit,) for benefit in benefits])
 
     @admin.display(description="Removed by User")
     def get_custom_benefits_removed_by_user(self, obj):
@@ -816,7 +816,7 @@ def get_custom_benefits_removed_by_user(self, obj):
         if not benefits:
             return "---"
 
-        return format_html_join("", "<p>{}</p>", benefits)
+        return format_html_join("", "<p>{}</p>", [(benefit,) for benefit in benefits])
 
     def rollback_to_editing_view(self, request, pk):
         """Delegate to the rollback_to_editing admin view."""
@@ -925,7 +925,7 @@ def other_years(self, obj):
 
             html += format_html(
                 dedent("""
-            <li><b>{year}</b>:"
+            <li><b>{year}</b>:
                 <ul>
                     <li><a target='_blank' href='{year_packages_url}'>List packages</a>
                     <li><a target='_blank' href='{year_benefits_url}'>List benefits</a>
@@ -1277,7 +1277,7 @@ def get_value(self, obj):
         """Return the asset value, linking to the file URL if applicable."""
         html = obj.value
         if obj.value and getattr(obj.value, "url", None):
-            html = format_html("<a href='{}' target='_blank'>{}</a>", (obj.value.url, obj.value))
+            html = format_html("<a href='{}' target='_blank'>{}</a>", obj.value.url, obj.value)
         return html
 
     @admin.display(description="Associated with")