From 84cba0933d5874e4dec08159f5992e36b25ec57b Mon Sep 17 00:00:00 2001 From: Adam Turner <9087854+aa-turner@users.noreply.github.com> Date: Mon, 31 Mar 2025 20:53:25 +0100 Subject: [PATCH] Meta: Minor updates to PR templates * Suggest "Mark as Final" * Suggest including the date in the Resolution field --- ...ted or Rejected.md => Mark a PEP as Accepted or Rejected.md} | 2 +- .../{Mark a PEP Final.md => Mark a PEP as Final.md} | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename .github/PULL_REQUEST_TEMPLATE/{Mark a PEP Accepted or Rejected.md => Mark a PEP as Accepted or Rejected.md} (76%) rename .github/PULL_REQUEST_TEMPLATE/{Mark a PEP Final.md => Mark a PEP as Final.md} (98%) diff --git a/.github/PULL_REQUEST_TEMPLATE/Mark a PEP Accepted or Rejected.md b/.github/PULL_REQUEST_TEMPLATE/Mark a PEP as Accepted or Rejected.md similarity index 76% rename from .github/PULL_REQUEST_TEMPLATE/Mark a PEP Accepted or Rejected.md rename to .github/PULL_REQUEST_TEMPLATE/Mark a PEP as Accepted or Rejected.md index 1aca40d5a88..b3c5ff00dd4 100644 --- a/.github/PULL_REQUEST_TEMPLATE/Mark a PEP Accepted or Rejected.md +++ b/.github/PULL_REQUEST_TEMPLATE/Mark a PEP as Accepted or Rejected.md @@ -8,6 +8,6 @@ If you're unsure about anything, just leave it blank and we'll take a look. * [ ] SC/PEP Delegate has formally accepted/rejected the PEP and posted to the ``Discussions-To`` thread * [ ] Pull request title in appropriate format (``PEP 123: Mark as Accepted``) * [ ] ``Status`` changed to ``Accepted``/``Rejected`` -* [ ] ``Resolution`` link points directly to SC/PEP Delegate official acceptance/rejected post +* [ ] ``Resolution`` field points directly to SC/PEP Delegate official acceptance/rejected post, including the date (e.g. `` `01-Jan-2000 `__ ``) * [ ] Acceptance/rejection notice added, if the SC/PEP delegate had major conditions or comments * [ ] ``Discussions-To``, ``Post-History`` and ``Python-Version`` up to date diff --git a/.github/PULL_REQUEST_TEMPLATE/Mark a PEP Final.md b/.github/PULL_REQUEST_TEMPLATE/Mark a PEP as Final.md similarity index 98% rename from .github/PULL_REQUEST_TEMPLATE/Mark a PEP Final.md rename to .github/PULL_REQUEST_TEMPLATE/Mark a PEP as Final.md index bd37727c7ac..04727041945 100644 --- a/.github/PULL_REQUEST_TEMPLATE/Mark a PEP Final.md +++ b/.github/PULL_REQUEST_TEMPLATE/Mark a PEP as Final.md @@ -7,7 +7,7 @@ If you're unsure about something, just leave it blank and we'll take a look. * [ ] Final implementation has been merged (including tests and docs) * [ ] PEP matches the final implementation * [ ] Any substantial changes since the accepted version approved by the SC/PEP delegate -* [ ] Pull request title in appropriate format (``PEP 123: Mark Final``) +* [ ] Pull request title in appropriate format (``PEP 123: Mark as Final``) * [ ] ``Status`` changed to ``Final`` (and ``Python-Version`` is correct) * [ ] Canonical docs/spec linked with a ``canonical-doc`` directive (or ``canonical-pypa-spec`` for packaging PEPs,