Skip to content

Commit ffe9e8e

Browse files
Apply suggestions from code review
Co-authored-by: Neil Girdhar <mistersheik@gmail.com>
1 parent cc29b81 commit ffe9e8e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

peps/pep-0791.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ can simplify the description of the accepted arguments for functions in both the
4242
:external+py3.14:mod:`math` and the new module.
4343

4444
Apparently, the :external+py3.14:mod:`math` module can't serve as a catch-all place
45-
for mathematical functions: we have also the :external+py3.14:mod:`cmath` and
45+
for mathematical functions since we also have the :external+py3.14:mod:`cmath` and
4646
:external+py3.14:mod:`statistics` modules. Let's do the same for integer-related
4747
functions. It provides shared context, which reduces verbosity in the
4848
documentation and conceptual load. It also aids discoverability through
@@ -89,8 +89,8 @@ As aliases in :external+py3.14:mod:`math` will be kept for an indefinite time
8989
How to Teach This
9090
=================
9191

92-
The new module will be a place to functions, that 1) accept
93-
:external+py3.14:class:`int`-like arguments and return also integers, 2) are
92+
The new module will be a place for functions, that 1) accept
93+
:external+py3.14:class:`int`-like arguments and also return integers, and 2) are
9494
also in the field of arbitrary-precision integer arithmetic, i.e. have no
9595
dependency on the platform floating-point format or behaviour and/or on the
9696
platform math library (``libm``).
@@ -116,7 +116,7 @@ Module name
116116
The chosen name seems consistent with one existing domain-specific mathematical module:
117117
:external+py3.14:mod:`cmath` (for complex numbers).
118118

119-
We should note, that the `Imath
119+
We note the `Imath
120120
<https://github.com/AcademySoftwareFoundation/Imath>`_ C++ library includes
121121
Python bindings with the same name. There is also an :pypi:`imath` project on
122122
PyPI, but only with two releases, with the most recent one four years ago. Its

0 commit comments

Comments
 (0)