Skip to content

Commit d9736cf

Browse files
zoobaAA-Turner
andauthored
Apply suggestions from code review
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
1 parent 21ffec0 commit d9736cf

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

peps/pep-0772.rst

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Created: 21-Jan-2025
99
Post-History:
1010
`18-Dec-2024 <https://discuss.python.org/t/74556/>`__,
1111
`21-Jan-2025 <https://discuss.python.org/t/77900/>`__,
12+
Replaces: 397, 486
1213

1314

1415
Abstract
@@ -937,7 +938,7 @@ Interaction with venv
937938
---------------------
938939

939940
An activated virtual environment, as implemented by the standard library
940-
``venv`` module, will modify the user's ``PATH`` environment variable to ensure
941+
:mod:`venv` module, will modify the user's ``PATH`` environment variable to ensure
941942
that the venv launcher will take precedence over other executables. As a result,
942943
when a venv has been activated, PyManager can only be launched by its aliases
943944
other than ``python``.
@@ -951,7 +952,7 @@ Backwards Compatibility
951952
=======================
952953

953954
In general, there are no compatibility guarantees to the install process between
954-
major versions (``3.x`` to ``3.y``), and so "having to use a different
955+
minor versions (``3.x`` to ``3.y``), and so "having to use a different
955956
installer" is not considered compatibility breakage. The versions of Python
956957
installed are only impacted by this change to the extent that the install method
957958
modified their behaviour. In general, most installs will be closer to the
@@ -1008,8 +1009,8 @@ selected) and require complicating the selection logic unnecessarily. This
10081009
change will be documented only.
10091010

10101011

1011-
Old py.exe launcher installed
1012-
-----------------------------
1012+
Old ``py.exe`` launcher installed
1013+
---------------------------------
10131014

10141015
Users who do not manually uninstall an old ``py.exe`` launcher will find that
10151016
both their existing and new installs of Python are found, though where versions
@@ -1138,18 +1139,18 @@ PyManager and override its configuration.
11381139
Impact on Existing PEPs
11391140
=======================
11401141

1141-
This proposal would effectively replace PEP 397 ("Python launcher for Windows")
1142-
and PEP 486 ("Make the Python Launcher aware of virtual environments") by
1142+
This proposal would effectively replace :pep:`397` ("Python launcher for Windows")
1143+
and :pep:`486` ("Make the Python Launcher aware of virtual environments") by
11431144
defining the same functionality as part of a new tool with the same name. Both
11441145
are already considered final, and the launcher is defined by its documentation
11451146
and normal compatibility processes. New functionality is based on the current
11461147
implementation, and not the original PEP text.
11471148

1148-
This proposal has no impact on PEP 394 ("The “python” Command on Unix-Like
1149+
This proposal has no impact on :pep`394` ("The “python” Command on Unix-Like
11491150
Systems"), and is believed to be consistent with it in devising an approach for
11501151
Windows that allows similar guidance to be given to users on all platforms.
11511152

1152-
This proposal has no impact on PEP 514 ("Python registration in the Windows
1153+
This proposal has no impact on :pep`514` ("Python registration in the Windows
11531154
registry"), and in fact improves our ability to follow it with a more flexible
11541155
system for registering our own runtimes. Tools that follow PEP 514 will find any
11551156
runtimes that choose to use the registration, regardless of how they were
@@ -1219,7 +1220,7 @@ Instructions currently referring to ``py`` for Windows can continue to do so, as
12191220
the install manager provides a practically equivalent command. Projects that
12201221
wish to provide Windows-specific instructions, such as by using the ``-V:``
12211222
or ``--install`` options to install the correct version, should also link to the
1222-
https://docs.python.org/using/windows.html documentation as guidance for
1223+
:ref:`documentation <using-on-windows>` as guidance for
12231224
ensuring that the install manager is installed.
12241225

12251226

@@ -1576,6 +1577,8 @@ PEP 723 introduced inline script metadata, a structured comment intended for
15761577
third-party tools to interpret and then launch a Python script in the correct
15771578
environment. An example taken from that PEP:
15781579

1580+
.. code:: python
1581+
15791582
# /// script
15801583
# requires-python = ">=3.11"
15811584
# dependencies = [
@@ -1596,7 +1599,6 @@ We could also detect the metadata and warn if the selected runtime does not
15961599
match its requirement, but this is not part of the initial proposal.
15971600

15981601

1599-
16001602
Open Issues
16011603
===========
16021604

0 commit comments

Comments
 (0)