whitespace

Author: iritkatriel

peps/pep-0765.rst

@@ -160,7 +160,7 @@ Appendix
 ========
 
 Below is an abridged version of a
-`research report<https://github.com/iritkatriel/finally/commits/main/README.md>`__
+`research report <https://github.com/iritkatriel/finally/commits/main/README.md>`__
 by Irit Katriel, which was posted on 9 Nov 2024.
 
 ``return`` in ``finally`` considered harmful
@@ -177,13 +177,13 @@ Method
 The analysis is based on the 8,000 most popular PyPI packages, in terms of number
 of downloads in the last 30 days. They were downloaded on the 17th-18th of
 October, using
-`a script<https://github.com/faster-cpython/tools/blob/main/scripts/download_packages.py>`__
+`a script <https://github.com/faster-cpython/tools/blob/main/scripts/download_packages.py>`__
 written by Guido van Rossum, which in turn relies on Hugo van Kemenade's
-`tool<https://hugovk.github.io/top-pypi-packages/>`__ that creates a list of the
+`tool <https://hugovk.github.io/top-pypi-packages/>`__ that creates a list of the
 most popular packages.
 
 Once downloaded, a
-`second script<https://github.com/iritkatriel/finally/blob/main/scripts/ast_analysis.py>`__
+`second script <https://github.com/iritkatriel/finally/blob/main/scripts/ast_analysis.py>`__
 was used to construct an AST for each file, and traverse it to identify ``break``,
 ``continue`` and ``return`` statements which are directly inside a ``finally`` block.
 
@@ -261,7 +261,7 @@ raised, but the ``return`` in the ``finally`` block would override the one in th
 
 > [!NOTE]
 > Following the
-> `discussion<https://discuss.python.org/t/an-analysis-of-return-in-finally-in-the-wild/70633/15>`__,
+> `discussion <https://discuss.python.org/t/an-analysis-of-return-in-finally-in-the-wild/70633/15>`__,
 > I repeated the analysis on a random selection of PyPI packages (to
 > analyze code written by *average* programmers). The sample contained
 > in total 77,398,892 lines of code with 316 instances of ``return``/``break``/``continue``
@@ -296,7 +296,7 @@ the feature, because this is where working code will need to change.  I did not
 contact the authors in these cases, so we will need to assess the difficulty of
 making these changes ourselves.
 
-- In `mosaicml<https://github.com/mosaicml/composer/blob/694e72159cf026b838ba00333ddf413185b4fb4f/composer/cli/launcher.py#L590>`__
+- In `mosaicml <https://github.com/mosaicml/composer/blob/694e72159cf026b838ba00333ddf413185b4fb4f/composer/cli/launcher.py#L590>`__
   there is a return in a finally at the end of the ``main`` function, after an ``except:``
   clause which swallows all exceptions. The return in the finally would swallow
   an exception raised from within the ``except:`` clause, but this seems to be the
@@ -305,7 +305,7 @@ making these changes ourselves.
   body of the ``except:`` clause by another ``try``-``except`` to swallow any
   exceptions from within it.
 
-- In `webtest<https://github.com/Pylons/webtest/blob/617a2b823c60e8d7c5f6e12a220affbc72e09d7d/webtest/http.py#L131>`__
+- In `webtest <https://github.com/Pylons/webtest/blob/617a2b823c60e8d7c5f6e12a220affbc72e09d7d/webtest/http.py#L131>`__
   there is a ``finally`` block that contains only ``return False``. It could be replaced
   by
 
@@ -315,27 +315,27 @@ making these changes ourselves.
         pass
     return False
 
-- In `kivy<https://github.com/kivy/kivy/blob/3b744c7ed274c1a99bd013fc55a5191ebd8a6a40/kivy/uix/codeinput.py#L204>`__
+- In `kivy <https://github.com/kivy/kivy/blob/3b744c7ed274c1a99bd013fc55a5191ebd8a6a40/kivy/uix/codeinput.py#L204>`__
   there is a ``finally`` that contains only a ``return`` statement. Since there is also a
   bare ``except`` just before it, in this case the fix will be to just remove the ``finally:``
   block and dedent the ``return`` statement.
 
-- In `logilab-common<https://forge.extranet.logilab.fr/open-source/logilab-common/-/blob/branch/default/test/data/module.py?ref_type=heads#L60>`__
+- In `logilab-common <https://forge.extranet.logilab.fr/open-source/logilab-common/-/blob/branch/default/test/data/module.py?ref_type=heads#L60>`__
   there is, once again, a ``finally`` clause that can be replace by an ``except BaseException``
   with the ``return`` dedented one level.
 
-- In `pluggy<https://github.com/pytest-dev/pluggy/blob/c760a77e17d512c3572d54d368fe6c6f9a7ac810/src/pluggy/_callers.py#L141>`__
+- In `pluggy <https://github.com/pytest-dev/pluggy/blob/c760a77e17d512c3572d54d368fe6c6f9a7ac810/src/pluggy/_callers.py#L141>`__
   there is a lengthy ``finally`` with two ``return`` statements (the second on line 182). Here the
   return value can be assigned to a variable, and the ``return`` itself can appear after we've
   exited the ``finally`` clause.
 
-- In `aws-sam-cli<https://github.com/aws/aws-sam-cli/blob/97e63dcc2738529eded8eecfef4b875abc3a476f/samcli/local/apigw/local_apigw_service.py#L721>`__
+- In `aws-sam-cli <https://github.com/aws/aws-sam-cli/blob/97e63dcc2738529eded8eecfef4b875abc3a476f/samcli/local/apigw/local_apigw_service.py#L721>`__
   there is a conditional return at the end of the block.
   From reading the code, it seems that the condition only holds when the exception has
   been handled. The conditional block can just move outside of the ``finally`` block and
   achieve the same effect.
 
-- In `scrappy<https://github.com/scrapy/scrapy/blob/52c072640aa61884de05214cb1bdda07c2a87bef/scrapy/utils/gz.py#L27>`__
+- In `scrappy <https://github.com/scrapy/scrapy/blob/52c072640aa61884de05214cb1bdda07c2a87bef/scrapy/utils/gz.py#L27>`__
   there is a ``finally`` that contains only a ``break`` instruction. Assuming that it was the intention
   to swallow all exceptions, it can be replaced by
 
@@ -377,10 +377,10 @@ The results indicate that ``return``, ``break`` and ``continue`` in a finally bl
 I thank:
 
 - Alyssa Coghlan for
-  `bringing this issue my attention<https://discuss.python.org/t/pep-760-no-more-bare-excepts/67182/97>`__.
+  `bringing this issue my attention <https://discuss.python.org/t/pep-760-no-more-bare-excepts/67182/97>`__.
 
 - Guido van Rossum and Hugo van Kemenade for the
-  `script<https://github.com/faster-cpython/tools/blob/main/scripts/download_packages.py>`__
+  `script <https://github.com/faster-cpython/tools/blob/main/scripts/download_packages.py>`__
   that downloads the most popular PyPI packages.
 
 - The many code authors I contacted for their responsiveness and grace.