Skip to content

Commit 1d43481

Browse files
astrofroghugovk
andauthored
Apply suggestions from code review by @hugovk
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
1 parent 9a8a9cd commit 1d43481

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

peps/pep-0771.rst

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ Rationale
7474
=========
7575

7676
A number of possible solutions have been extensively and vigorously discussed by
77-
the community for several years, including in `this DPO threadq
77+
the community for several years, including in `this DPO thread
7878
<https://discuss.python.org/t/adding-a-default-extra-require-environment/4898/38>`__
7979
as well as in numerous issues and pull requests. The solution that will be
8080
presented below:
@@ -128,7 +128,7 @@ produce the example ``Default-Extra`` entries presented in the previous section
128128
129129
[project]
130130
default-optional-dependencies = [
131-
"recommended"
131+
"recommended",
132132
]
133133
134134
and:
@@ -150,7 +150,7 @@ If extras are explicitly given in a dependency specification, the default
150150
extras are not installed. Otherwise, the default extras are used.
151151

152152
For example, if a package
153-
defines a ``extra1`` default extra as well as a non-default ``extra2``
153+
defines an ``extra1`` default extra as well as a non-default ``extra2``
154154
extra, then if a user was to install the package with::
155155

156156
pip install package
@@ -354,7 +354,7 @@ properly document the options available to users in terms of installation.
354354
Reference Implementation
355355
========================
356356

357-
The following branch contains a modified version of the `flit
357+
The following branch contains a modified version of the `Flit
358358
<https://flit.pypa.io/en/stable/>`_ package which recognizes the
359359
``default-optional-dependencies`` key in ``pyproject.toml`` and adds the
360360
relevant ``Default-Extra:`` metadata to the build package:
@@ -372,15 +372,15 @@ test out different scenarios and use cases described in this PEP:
372372

373373
https://github.com/astrofrog/pep-771-demo
374374

375-
The implementations above are proof-of-concepts at this time, do not include any
375+
The implementations above are proofs-of-concept at this time, do not include any
376376
tests or documentation in the respective packages, and the existing changes have
377377
not yet been reviewed by the relevant maintainers. Nevertheless, they are
378378
functional enough to allow for interested maintainers to try these out.
379379

380380
Rejected Ideas
381381
==============
382382

383-
Syntax for unselecting extras
383+
Syntax for deselecting extras
384384
-----------------------------
385385

386386
One of the main competing approaches was as follows: instead of having defaults
@@ -431,7 +431,7 @@ The idea would be that dependencies installed as part of the 'empty' extras
431431
would only get installed if another extra was not specified. An implementation
432432
of this was proposed in https://github.com/pypa/setuptools/pull/1503, but it
433433
was found that there would be no way to make this work without breaking
434-
compatibility with existing usage. For example, packages using setuptools via
434+
compatibility with existing usage. For example, packages using Setuptools via
435435
a ``setup.py`` file can do::
436436

437437
setup(
@@ -441,7 +441,7 @@ a ``setup.py`` file can do::
441441

442442

443443
which is valid and equivalent to having ``package_a`` being defined in
444-
``install_requires``, so changing the meaning of the empty string requires would
444+
``install_requires``, so changing the meaning of the empty string would
445445
break compatibility.
446446

447447
In addition, no other string (such as ``'default'``) can be used as a special

0 commit comments

Comments
 (0)