Skip to content

Commit 1cd7a82

Browse files
encukouAA-Turner
andauthored
Apply suggestions from code review
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
1 parent 19a31f7 commit 1cd7a82

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

peps/pep-0793.rst

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -433,9 +433,9 @@ It should be moved to a HOWTO in the documentation.
433433
Make sure that it does not use its second argument (``PyModuleDef``),
434434
as it will be called with ``NULL``.
435435
Instead of the argument, use the existing ``PyModuleDef`` struct directly.
436-
#. If using multiple ``Py_mod_create`` slots, consolidate them: pick one of
436+
#. If using multiple ``Py_mod_exec`` slots, consolidate them: pick one of
437437
the functions, or write a new one, and call the others from it.
438-
Remove all but one ``Py_mod_create`` slots.
438+
Remove all but one ``Py_mod_exec`` slots.
439439
#. Make a copy of the existing ``PyModuleDef_Slot`` array pointed to by
440440
the ``m_slots`` member of your ``PyModuleDef``. If you don't have an
441441
existing slots array, create one like this:
@@ -591,13 +591,14 @@ important. So, it might be OK to leave this to a later change.
591591
Footnotes
592592
=========
593593

594-
.. [#multiexec] A `quick survey <https://github.com/python/peps/pull/4435/files#r2105731314>`_
595-
of multiple ``Py_mod_exec`` slots found zero uses in the top 15,000 PyPI
596-
projects, and three in the stardard library (including tests for the
597-
feature).
594+
.. [#multiexec] A `quick survey`_ of multiple ``Py_mod_exec`` slots found zero
595+
uses in the top 15,000 PyPI projects, and three in the stardard library
596+
(including tests for the feature).
598597
The easy workaround is consolidating the ``exec`` functions; see
599598
:ref:`pep793-porting-notes` for details.
600599
600+
.. _quick survey: https://github.com/python/peps/pull/4435#discussion_r2105731314
601+
601602
602603
Copyright
603604
=========

0 commit comments

Comments
 (0)