Skip to content

Commit 0bb65f9

Browse files
authored
PEP 751: address some feedback (#4104)
1 parent 85c1106 commit 0bb65f9

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

peps/pep-0751.rst

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,9 @@ specified for the same reason.
158158
- Table
159159
- Record of the tool that generated the lock file.
160160
- Enough details SHOULD be provided such that the lock
161-
file from the details in this table (provided the same I/O data is available,
162-
e.g., Dependabot if only files from a repository is necessary to run the
163-
command).
161+
file from the details in this table can be reproduced (provided the same I/O
162+
data is available, e.g., Dependabot if only files from a repository is
163+
necessary to run the command).
164164

165165

166166
``locker.name``
@@ -358,7 +358,10 @@ specified for the same reason.
358358
- Array of tables
359359
- A record of the dependency requirements of the package and version.
360360
- The values MUST semantically match what's provided by the package version via
361-
:ref:`packaging:core-metadata-requires-dist`.
361+
:ref:`packaging:core-metadata-requires-dist` for all dependencies referenced
362+
in the lock file (i.e all base dependencies plus all dependencies for extras
363+
referenced in the lock file); lock files MAY list all dependencies for unused
364+
extras if desired.
362365
- Values in the array SHOULD be written as inline tables, sorted
363366
lexicographically by ``name``, then by ``feature`` with the lack of that key
364367
sorting first.
@@ -783,8 +786,9 @@ Expectations for Installers
783786
- Installers MUST error out if a package version lacks a way to install into the
784787
chosen environment.
785788
- Installers MUST support installing into an empty environment
786-
- Installers SHOULD support syncing a pre-existing environment to match the lock
787-
file.
789+
- Installers SHOULD support uninstalling all packages in a pre-existing
790+
environment and then installing into it (sometimes referred to as *syncing*
791+
an environment to the lock file).
788792
- Installers MAY support a way to install into a pre-existing environment that
789793
tries to keep packages not listed in the lock file working.
790794

0 commit comments

Comments
 (0)