Skip to content

Commit 5d73ed7

Browse files
authored
Apply suggestions from code review
1 parent 2a0fcd8 commit 5d73ed7

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

development-tools/clang.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,11 @@ Then, run ``./configure`` with the relevant flags:
103103
* ASan: ``--with-address-sanitizer --without-pymalloc``
104104
* UBsan: ``--with-undefined-behavior-sanitizer``
105105

106-
Disabling pymalloc for ASan helps uncover more bugs since it is more effective
107-
with the system allocator (pymalloc doesn't add padding in between the allocated
108-
objects and doesn't poison/annotate the memory it manages for ASan).
106+
The ``--without-pymalloc`` option is not necessary (tests should pass without it),
107+
but disabling pymalloc helps ASan uncover more bugs (ASan does not track
108+
individual allocations done by pymalloc).
109109

110-
It is also OK to specify both sanitizers.
110+
It is OK to specify both sanitizers.
111111

112112
After that, run ``make`` and ``make test`` as usual.
113113
Note that ``make`` itself may fail with a sanitizer failure,

0 commit comments

Comments
 (0)