gh-127727: Warn when running a virtual environment created for a different minor Python version#149715
gh-127727: Warn when running a virtual environment created for a different minor Python version#149715sepehr-rs wants to merge 13 commits into
Conversation
…imeWarning on minor-version mismatch.
|
I’m seeing the “Lint / lint” check fail in CI, but I can’t find a concrete error message in the job logs, and |
|
There are lines with whitespaces only but the GH UI may not show them properly. |
|
Thanks a lot, lint check is passing now! |
FFY00
left a comment
There was a problem hiding this comment.
Thanks @sepehr-rs!
The PR mostly looks okay. I have some questions inline, and the following suggestions:
- Also check
version_info, in addition toversion - Raise a warning on a malformed
versionorversion_infofields - Add test(s)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Hi @FFY00! Thank you for your kind review and suggestions. |
|
Thanks for making the requested changes! @FFY00: please review the changes made to this pull request. |
|
@sepehr-rs there seems to still be a test failure. |
|
Hi @vsajip, thanks for pointing that out. |
|
Hi @vsajip, just a gentle ping; the relevant CI checks are passing now. Happy to address anything else if you have further feedback. |
Attempting to fix #127727, feedback is very welcome!