gh-149701: Fully silence potential hash -r error

[genericallyterrible]

• Issue: source venv/bin/activate returns non-zero on systems with hashing disabled #149701

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[python-cla-bot]

All commit authors signed the Contributor License Agreement.

[sepehr-rs]

Tested on Debian 13, can confirm this fix works.

bash-5.2$ set +h
bash-5.2$ hash
bash: hash: hashing disabled
bash-5.2$ source .venv/bin/activate
(.venv) bash-5.2$ echo $?
0

[genericallyterrible]

After digging, seems the same thing happened previously in virtualenv: pypa/virtualenv#2717

New here so I'm not sure if tests may need updated to watch for regressions.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[zware]

Yes, I think this is worth adding a test along the lines of what was done in the virtualenv change.

[vsajip]

As per @zware's comment, I agree that a test should be added.

[bedevere-app]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[genericallyterrible]

I have made the requested changes; please review again

I copied the preceding test, test_deactivate_with_strict_bash_opts, and added set +h before the source command.

Sorry for the noise, I mistakenly merged main through github instead of rebasing my commits locally.

[bedevere-app]

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

[zware]

LGTM!

[miss-islington-app]

Thanks @genericallyterrible for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

[miss-islington-app]

Thanks @genericallyterrible for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

[miss-islington-app]

Thanks @genericallyterrible for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

[bedevere-app]

GH-149757 is a backport of this pull request to the 3.15 branch.

[bedevere-app]

GH-149758 is a backport of this pull request to the 3.14 branch.

[bedevere-app]

GH-149759 is a backport of this pull request to the 3.13 branch.