Skip to content

gh-138489: Add build-details.json generation to PC/layout#149153

Merged
zooba merged 5 commits into
python:mainfrom
zooba:gh-138489
May 15, 2026
Merged

gh-138489: Add build-details.json generation to PC/layout#149153
zooba merged 5 commits into
python:mainfrom
zooba:gh-138489

Conversation

@zooba

@zooba zooba commented Apr 29, 2026

Copy link
Copy Markdown
Member

@zooba

zooba commented Apr 29, 2026

Copy link
Copy Markdown
Member Author

Supersedes #138490, and deliberately omits changes to the (deprecated) MSI installer, largely because there's no real value in dealing with the complexity of having multiple overlapping installs.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32469300 | 📁 Comparing cc522fc against main (f1588d4)

  🔍 Preview build  

14 files changed · ± 14 modified

± Modified

@zooba

zooba commented May 8, 2026

Copy link
Copy Markdown
Member Author

@hugovk Any chance of a beta 2 exception for this one (adds a new file to the file system layout)? No functional change to the runtime, and the PEP isn't new, we just never got around to implementing it for Windows until now.

@hugovk

hugovk commented May 8, 2026

Copy link
Copy Markdown
Member

@zooba Yes, that's fine. Thanks for working on this.

@zooba

zooba commented May 11, 2026

Copy link
Copy Markdown
Member Author

For reviewers' sake, here's a sample file as generated by this script for a regular amd64 release from main:

{
  "schema_version": "1.0",
  "base_prefix": ".",
  "base_interpreter": "python.exe",
  "platform": "win-amd64",
  "language": {
    "version": "3.16",
    "version_info": {
      "major": 3,
      "minor": 16,
      "micro": 0,
      "releaselevel": "alpha",
      "serial": 0
    }
  },
  "implementation": {
    "name": "cpython",
    "cache_tag": "cpython-316",
    "version": {
      "major": 3,
      "minor": 16,
      "micro": 0,
      "releaselevel": "alpha",
      "serial": 0
    }
  },
  "abi": {
    "flags": [],
    "extension_suffix": ".cp316-win_amd64.pyd",
    "stable_abi_suffix": ".pyd"
  },
  "suffixes": {
    "source": [
      ".py"
    ],
    "bytecode": [
      ".pyc"
    ],
    "extensions": [
      ".cp316-win_amd64.pyd",
      ".pyd"
    ]
  },
  "libpython": {
    "dynamic": "python316.dll",
    "dynamic_stableabi": "python3.dll",
    "link_extensions": true
  },
  "c_api": {
    "headers": "Include"
  }
}

@zooba zooba requested a review from chris-eibl May 14, 2026 12:50

@chris-eibl chris-eibl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am away from my dev box, though, and thus couldn't test locally.

Comment thread PC/layout/support/builddetails.py Outdated
Comment thread PC/layout/support/builddetails.py
@zooba zooba requested a review from vsajip as a code owner May 14, 2026 22:31
@zooba

zooba commented May 14, 2026

Copy link
Copy Markdown
Member Author

Whoops, pushed test fixes for the wrong PR. Reverted now - sorry Vinay

@zooba zooba merged commit 4aa296f into python:main May 15, 2026
52 checks passed
@zooba zooba deleted the gh-138489 branch May 15, 2026 12:51
@zooba zooba added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 15, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented May 15, 2026

Copy link
Copy Markdown

GH-149878 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 15, 2026
zooba added a commit that referenced this pull request May 15, 2026
…149153)

(cherry picked from commit 4aa296f)

Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants