Skip to content

gh-148906: fix scaling of descriptors on free-threading#148915

Merged
kumaraditya303 merged 6 commits into
python:mainfrom
kumaraditya303:descriptor-scaling
May 13, 2026
Merged

gh-148906: fix scaling of descriptors on free-threading#148915
kumaraditya303 merged 6 commits into
python:mainfrom
kumaraditya303:descriptor-scaling

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Apr 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

On this PR:

❯ ./python.exe Tools/ftscalingbench/ftscalingbench.py --threads=10 descriptor
Running benchmarks with 10 threads
descriptor                 4.1x faster

@bedevere-app bedevere-app Bot mentioned this pull request Apr 23, 2026
Closed
@kumaraditya303 kumaraditya303 added performance Performance or resource usage topic-free-threading labels Apr 23, 2026
colesbury
colesbury reviewed Apr 23, 2026
View reviewed changes
Comment thread Objects/typeobject.c Outdated
@kumaraditya303 kumaraditya303 requested a review from colesbury May 13, 2026 11:00
colesbury
colesbury approved these changes May 13, 2026
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Objects/typeobject.c Outdated
Comment thread Objects/typeobject.c Outdated
@kumaraditya303 kumaraditya303 added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 13, 2026
@kumaraditya303 kumaraditya303 merged commit 94bca40 into python:main May 13, 2026
54 checks passed
@miss-islington-app

miss-islington-app Bot commented May 13, 2026

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app

bedevere-app Bot commented May 13, 2026

Copy link
Copy Markdown

GH-149798 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 13, 2026
@kumaraditya303 kumaraditya303 deleted the descriptor-scaling branch May 13, 2026 17:36
kumaraditya303 added a commit that referenced this pull request May 13, 2026
@miss-islington @kumaraditya303
[3.15] gh-148906: fix performance scaling of descriptors on free-thre…
166c56b 
…ading (GH-148915) (#149798)

gh-148906: fix performance scaling of descriptors on free-threading (GH-148915)
(cherry picked from commit 94bca40)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

performance Performance or resource usage skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kumaraditya303 @colesbury