Skip to content

Commit fbe00f8

Browse files
committed
Check param kinds by name (code review)
1 parent 7ac8275 commit fbe00f8

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

Lib/functools.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -921,10 +921,8 @@ def _get_singledispatch_annotated_param(func, *, _inside_dispatchmethod=False):
921921
import inspect
922922
try:
923923
param = list(inspect.signature(func).parameters.values())[idx]
924-
# True for positional "(arg)" and positional-only "(arg, /)" parameters.
925-
# True for variadic positional "(*args)" parameters for backward compatibility.
926-
# False for keyword-only "(*, arg)" and keyword variadic "(**args)" parameters.
927-
if param.kind < 3:
924+
# Allow variadic positional "(*args)" parameters for backward compatibility.
925+
if param.kind not in (inspect.Parameter.KEYWORD_ONLY, inspect.Parameter.VAR_KEYWORD):
928926
return param.name
929927
except IndexError:
930928
pass

0 commit comments

Comments
 (0)