Review

Author: StanFromIreland

.github/workflows/reusable-idle-help-doc.yml

@@ -27,7 +27,9 @@ jobs:
       with:
         python-version: '3'
     - name: 'Regenerate Lib/idlelib/help.html'
-      run: python ../Tools/build/generate_idle_help.py
+      run: |
+        mkdir -v html/  # trick make into skipping the dependency target
+        make idlehelp
       working-directory: Doc
     - name: 'Check for changes'
       run: |

Tools/build/compute-changes.py

@@ -167,6 +167,8 @@ def process_changed_files(changed_files: Set[Path]) -> Outputs:
                 has_platform_specific_change = False
             if file.name == "reusable-docs.yml":
                 run_docs = True
+            if file.name == "reusable-idle-help-doc.yml":
+                run_idle_help_doc = True
             if file.name == "reusable-windows-msi.yml":
                 run_windows_msi = True
             if file.name == "reusable-macos.yml":
@@ -204,7 +206,8 @@ def process_changed_files(changed_files: Set[Path]) -> Outputs:
             run_docs = True
 
         # Check for changed IDLE docs
-        if file == Path("Doc/library/idle.rst"):
+        if file in (Path("Doc/library/idle.rst"),
+                    Path("Tools/build/generate_idle_help.py")):
             run_idle_help_doc = True
 
         # Check for changed MSI installer-related files

Tools/build/generate_idle_help.py

@@ -20,9 +20,14 @@
 version.
 """
 
+from os.path import abspath, dirname, join
+
+
 def copy_strip():
-    src = 'build/html/library/idle.html'
-    dst = '../Lib/idlelib/help.html'
+    src = join(abspath(dirname(dirname(dirname(__file__)))),
+               'Doc', 'build', 'html', 'library', 'idle.html')
+    dst = join(abspath(dirname(dirname(dirname(__file__)))),
+               'Lib', 'idlelib', 'help.html')
 
     with open(src, encoding="utf-8") as inn, open(dst, 'w', encoding="utf-8") as out:
         copy = False