Address review comments

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

Author: 3 people

Doc/library/os.path.rst

@@ -117,13 +117,13 @@ the :mod:`glob` module.)
         >>> os.path.commonpath(['/usr/lib', '/usr/local/lib'])
         '/usr'
 
-   .. versionchanged:: 3.15
-      Deprecated in favor of :func:`os.path.commonpath` for path prefixes and
-      :func:`string.commonprefix` for string prefixes.
-
    .. versionchanged:: 3.6
       Accepts a :term:`path-like object`.
 
+   .. deprecated:: next
+      Deprecated in favor of :func:`os.path.commonpath` for path prefixes and
+      :func:`string.commonprefix` for string prefixes.
+
 
 .. function:: dirname(path, /)
 

Doc/library/string.rst

@@ -994,9 +994,9 @@ Helper functions
 .. function:: commonprefix(list, /)
 
    Return the longest string prefix (taken character-by-character) that is a
-   prefix of all string in  *list*.  If *list* is empty, return the empty string
-   (``''``).
+   prefix of all the strings in *list*.  If *list* is empty, return the empty
+   string (``''``).
 
-   .. versionadded:: 3.15
+   .. versionadded:: next
 
       Moved to the :mod:`string` module from the :mod:`os.path` module.

Lib/genericpath.py

@@ -107,7 +107,8 @@ def commonprefix(m, /):
     "Given a list of pathnames, returns the longest common leading component"
     import warnings
     warnings.warn('os.path.commonprefix() is deprecated. Use '
-                  'os.path.commonpath() or string.commonprefix() instead.',
+                  'os.path.commonpath() for longest path prefix, or '
+                  'string.commonprefix() for longest string prefix.',
                   category=DeprecationWarning,
                   stacklevel=2)
     import string

Lib/string/__init__.py

@@ -49,8 +49,9 @@ def capwords(s, sep=None):
 
 
 def commonprefix(m, /):
-    "Given a list of strings, returns the longest common leading component"
-    if not m: return ''
+    """Given a list of strings, returns the longest common leading component."""
+    if not m:
+        return ''
     # Note that previously this function was in the 'os.path' module, hence the
     # handling for paths. Maintain compatibility so users have a 1-to-1 drop-in.
     # Some people pass in a list of pathname parts to operate in an OS-agnostic