Skip to content

Commit d6ca1b3

Browse files
committed
fixup! gh-138122: Refactor the CLI of profile.sampling into subcommands
1 parent db2ed3b commit d6ca1b3

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

Lib/profiling/sampling/sample.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
from .gecko_collector import GeckoCollector
1414
from .constants import (
1515
PROFILING_MODE_WALL,
16+
PROFILING_MODE_CPU,
17+
PROFILING_MODE_GIL,
1618
PROFILING_MODE_ALL,
1719
)
1820
try:

Lib/test/test_profiling/test_sampling_profiler/test_modes.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -444,10 +444,11 @@ def test_mode_constants_are_defined(self):
444444

445445
def test_parse_mode_function(self):
446446
"""Test the _parse_mode function with all valid modes."""
447-
self.assertEqual(profiling.sampling.sample._parse_mode("wall"), 0)
448-
self.assertEqual(profiling.sampling.sample._parse_mode("cpu"), 1)
449-
self.assertEqual(profiling.sampling.sample._parse_mode("gil"), 2)
447+
from profiling.sampling.cli import _parse_mode
448+
self.assertEqual(_parse_mode("wall"), 0)
449+
self.assertEqual(_parse_mode("cpu"), 1)
450+
self.assertEqual(_parse_mode("gil"), 2)
450451

451452
# Test invalid mode raises KeyError
452453
with self.assertRaises(KeyError):
453-
profiling.sampling.sample._parse_mode("invalid")
454+
_parse_mode("invalid")

Misc/NEWS.d/3.15.0a2.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ Add :func:`os.reload_environ` to ``os.__all__``.
388388
.. nonce: L13UCV
389389
.. section: Library
390390
391-
Fix :func:`profiling.sampling.sample` incorrectly handling a
391+
Fix ``profiling.sampling.sample()`` incorrectly handling a
392392
:exc:`FileNotFoundError` or :exc:`PermissionError`.
393393

394394
..
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
Add a new ``--live`` mode to the tachyon profiler in
2-
:mod:`profiling.sampling` module. This mode consist of a live TUI that
2+
:mod:`!profiling.sampling` module. This mode consist of a live TUI that
33
displays real-time profiling statistics as the target application runs,
44
similar to ``top``. Patch by Pablo Galindo

0 commit comments

Comments
 (0)