Add tests

Author: aisk

Lib/test/test_fcntl.py

@@ -288,6 +288,15 @@ def test_bad_fd(self):
         with self.assertRaises(OSError):
             fcntl.fcntl(fd, fcntl.F_DUPFD, b'\0' * 2048)
 
+    @unittest.skipUnless(hasattr(fcntl, 'preallocate'), 'need fcntl.preallocate')
+    def test_preallocate(self):
+        self.f = open(TESTFN, 'wb+')
+        fd = self.f.fileno()
+
+        result = fcntl.preallocate(fd, fcntl.F_ALLOCATECONTIG, fcntl.F_PEOFPOSMODE, 0, 1024)
+        self.assertIsInstance(result, int)
+        self.assertEqual(result, 1024)
+
 
 if __name__ == '__main__':
     unittest.main()

Modules/clinic/fcntlmodule.c.h

@@ -503,6 +503,8 @@ fcntl_lockf_impl(PyObject *module, int fd, int code, PyObject *lenobj,
 }
 
 
+#ifdef F_PREALLOCATE
+
 /*[clinic input]
 fcntl.preallocate
 
@@ -521,9 +523,8 @@ This is a wrapper around the F_PREALLOCATE fcntl command.
 static PyObject *
 fcntl_preallocate_impl(PyObject *module, int fd, int flags, int posmode,
                        long offset, long length)
-/*[clinic end generated code: output=4934b8a4dc1f5dc1 input=b8e76ad8be51da32]*/
+/*[clinic end generated code: output=4934b8a4dc1f5dc1 input=4c1a9d46551420ed]*/
 {
-#ifdef F_PREALLOCATE
     int ret;
     int async_err = 0;
 
@@ -550,12 +551,10 @@ fcntl_preallocate_impl(PyObject *module, int fd, int flags, int posmode,
     }
 
     return PyLong_FromLong((long)fstore.fst_bytesalloc);
-#else
-    PyErr_SetString(PyExc_OSError, "F_PREALLOCATE not supported on this platform");
-    return NULL;
-#endif
 }
 
+#endif /* F_PREALLOCATE */
+
 /* List of functions */
 
 static PyMethodDef fcntl_methods[] = {
@@ -754,6 +753,12 @@ all_ins(PyObject* m)
 #ifdef F_ALLOCATEPERSIST
     if (PyModule_AddIntMacro(m, F_ALLOCATEPERSIST)) return -1;
 #endif
+#ifdef F_PEOFPOSMODE
+    if (PyModule_AddIntMacro(m, F_PEOFPOSMODE)) return -1;
+#endif
+#ifdef F_VOLPOSMODE
+    if (PyModule_AddIntMacro(m, F_VOLPOSMODE)) return -1;
+#endif
 
 /* FreeBSD specifics */
 #ifdef F_DUP2FD