Skip to content

Commit ccf93cf

Browse files
Address review comment
1 parent e44e9df commit ccf93cf

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

Lib/test/test_csv.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -922,6 +922,7 @@ def test_dict_reader_set_fieldnames(self):
922922
fieldnames = ["a", "b", "c"]
923923
f = StringIO()
924924
reader = csv.DictReader(f)
925+
self.assertIsNone(reader.fieldnames)
925926
reader.fieldnames = fieldnames
926927
self.assertEqual(reader.fieldnames, fieldnames)
927928

@@ -940,7 +941,7 @@ def test_dict_writer_fieldnames_accepts_list(self):
940941
def test_dict_reader_fieldnames_is_optional(self):
941942
f = StringIO()
942943
reader = csv.DictReader(f, fieldnames=None)
943-
self.assertEqual(reader.fieldnames, None)
944+
self.assertIsNone(reader.fieldnames)
944945

945946
def test_read_dict_fields(self):
946947
with TemporaryFile("w+", encoding="utf-8") as fileobj:
@@ -1366,11 +1367,12 @@ class TestSniffer(unittest.TestCase):
13661367

13671368
sample17 = ["letter,offset"]
13681369
sample17.extend(f"{chr(ord('a') + i)},{i}" for i in range(20))
1369-
sample17.append("v,twenty_one")
1370+
sample17.append("v,twenty_one") # 'u' was skipped
13701371
sample17 = '\n'.join(sample17)
1372+
13711373
sample18 = ["letter,offset"]
13721374
sample18.extend(f"{chr(ord('a') + i)},{i}" for i in range(21))
1373-
sample18.append("v,twenty_one")
1375+
sample18.append("v,twenty_one") # 'u' was not skipped
13741376
sample18 = '\n'.join(sample18)
13751377

13761378
def test_issue43625(self):
@@ -1396,8 +1398,8 @@ def test_has_header_regex_special_delimiter(self):
13961398

13971399
def test_has_header_checks_20_rows(self):
13981400
sniffer = csv.Sniffer()
1399-
self.assertIs(sniffer.has_header(self.sample17), False)
1400-
self.assertIs(sniffer.has_header(self.sample18), True)
1401+
self.assertFalse(sniffer.has_header(self.sample17))
1402+
self.assertTrue(sniffer.has_header(self.sample18))
14011403

14021404
def test_guess_quote_and_delimiter(self):
14031405
sniffer = csv.Sniffer()
@@ -1453,7 +1455,6 @@ def test_delimiters(self):
14531455
self.assertRaisesRegex(csv.Error, "Could not determine delimiter",
14541456
sniffer.sniff, self.sample16)
14551457

1456-
14571458
def test_doublequote(self):
14581459
sniffer = csv.Sniffer()
14591460
dialect = sniffer.sniff(self.header1)

0 commit comments

Comments
 (0)