Format before colourization

Author: savannahostrowski

Lib/argparse.py

@@ -688,11 +688,30 @@ def _expand_help(self, action):
                 params[name] = value.__name__
         if params.get('choices') is not None:
             params['choices'] = ', '.join(map(str, params['choices']))
-        # Before interpolating, wrap the values with color codes
+        
         t = self._theme
-        for name, value in params.items():
-            params[name] = f"{t.interpolated_value}{value}{t.reset}"
-        return help_string % params
+
+        if not t.reset:
+            return help_string % params
+        
+        # Format first to preserve types for specifiers, like %x that require int.
+        def colorize(match):
+            spec, name = match.group(0, 1)
+            if spec == '%%':
+                return '%'
+            if name in params:
+                formatted = spec % {name: params[name]}
+                return f'{t.interpolated_value}{formatted}{t.reset}'
+            return spec
+
+        # Match %% (literal %) or %(name)... format specifiers
+        result = _re.sub(r'%%|%\((\w+)\)[^a-z]*[a-z]', colorize,
+                         help_string, flags=_re.IGNORECASE)
+
+        # Check for invalid/unmatched % specifiers
+        if '%' in result:
+            raise ValueError(f"invalid format specifier in: {help_string!r}")
+        return result
 
     def _iter_indented_subactions(self, action):
         try:

Lib/test/test_argparse.py

@@ -7663,6 +7663,22 @@ def test_backtick_markup_special_regex_chars(self):
         help_text = parser.format_help()
         self.assertIn(f'{prog_extra}grep "foo.*bar" | sort{reset}', help_text)
 
+    def test_help_with_format_specifiers(self):
+        # GH-142950: format specifiers like %x should work with color=True
+        parser = argparse.ArgumentParser(prog='PROG', color=True)
+        parser.add_argument('--hex', type=int, default=255,
+                            help='hex: %(default)x')
+        parser.add_argument('--str', default='test',
+                            help='str: %(default)s')
+
+        help_text = parser.format_help()
+
+        interp = self.theme.interpolated_value
+        reset = self.theme.reset
+
+        self.assertIn(f'hex: {interp}ff{reset}', help_text)
+        self.assertIn(f'str: {interp}test{reset}', help_text)
+
     def test_print_help_uses_target_file_for_color_decision(self):
         parser = argparse.ArgumentParser(prog='PROG', color=True)
         parser.add_argument('--opt')