Cast before shifting

markshannon · markshannon · commit aa4ddf08574e · 2025-04-15T16:54:34.000+01:00
diff --git a/Include/internal/pycore_stackref.h b/Include/internal/pycore_stackref.h
@@ -257,7 +257,8 @@ static inline intptr_t
 PyStackRef_UntagInt(_PyStackRef i)
 {
     assert((i.bits & Py_INT_TAG) == Py_INT_TAG);
-    return Py_ARITHMETIC_RIGHT_SHIFT(intptr_t, i.bits, 2);
+    intptr_t val = (intptr_t)i.bits;
+    return Py_ARITHMETIC_RIGHT_SHIFT(intptr_t, val, 2);
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -257,7 +257,8 @@ static inline intptr_t`
`257`	`257`	`PyStackRef_UntagInt(_PyStackRef i)`
`258`	`258`	`{`
`259`	`259`	`assert((i.bits & Py_INT_TAG) == Py_INT_TAG);`
`260`		`- return Py_ARITHMETIC_RIGHT_SHIFT(intptr_t, i.bits, 2);`
	`260`	`+ intptr_t val = (intptr_t)i.bits;`
	`261`	`+ return Py_ARITHMETIC_RIGHT_SHIFT(intptr_t, val, 2);`
`261`	`262`	`}`
`262`	`263`
`263`	`264`