Skip to content

Commit a34fa62

Browse files
Simplify flags for now
1 parent 13bfc68 commit a34fa62

File tree

2 files changed

+2131
-1732
lines changed

2 files changed

+2131
-1732
lines changed

Tools/jit/_targets.py

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,7 @@ def build(self, out: pathlib.Path, *, force: bool = False) -> None:
209209
and hosted_stencil.exists()
210210
):
211211
if jit_stencils_digest.read_text() == digest:
212+
print("Skipping JIT stencil generation")
212213
return
213214

214215
stencil_groups = asyncio.run(self._build_stencils())
@@ -227,25 +228,26 @@ def build(self, out: pathlib.Path, *, force: bool = False) -> None:
227228
copy_stencils = True
228229

229230
else:
230-
JIT_ARGS = {
231-
"--enable-experimental-jit",
232-
"--with-lto",
233-
"--enable-optimizations",
234-
}
231+
# TODO: Need to revisit which flags are actually needed here
232+
# JIT_ARGS = {
233+
# "--enable-experimental-jit",
234+
# "--with-lto",
235+
# "--enable-optimizations",
236+
# }
235237
makefile = out / "Makefile"
236238
match = re.search(r"CONFIG_ARGS\s*=\s*'(.*)'", makefile.read_text())
237239
assert match is not None
238240
config_args = match.group(1)
239-
print(config_args)
240241
if config_args:
241-
copy_stencils = all(
242-
arg in JIT_ARGS for arg in config_args.split()
242+
# copy_stencils = all(
243+
# arg in JIT_ARGS for arg in config_args.split()
244+
# )
245+
copy_stencils = not ("--with-debug" in config_args) and not (
246+
"--disable-gil" in config_args
243247
)
244248

245-
copy_stencils = copy_stencils and self.triple in SUPPORTED_TRIPLES
246-
print(self.triple)
249+
copy_stencils = copy_stencils and self.stencil_name in SUPPORTED_TRIPLES
247250
if copy_stencils:
248-
print("COPYING STENCILS")
249251
shutil.copy(jit_stencils, hosted_stencil)
250252
except FileNotFoundError:
251253
# another process probably already moved the file

0 commit comments

Comments
 (0)