improve test docs

Author: picnixz

Lib/test/test_sqlite3/test_dbapi.py

@@ -1070,8 +1070,8 @@ def test_execute_many_not_iterable(self):
         with self.assertRaises(TypeError):
             self.cu.executemany("insert into test(income) values (?)", 42)
 
-    @subTests("params_class", (ParamsCxCloseInIterMany, ParamsCxCloseInNext))
-    def test_executemany_use_after_close(self, params_class):
+    @subTests("params_factory", (ParamsCxCloseInIterMany, ParamsCxCloseInNext))
+    def test_executemany_use_after_close(self, params_factory):
         # Prevent SIGSEGV with iterable of parameters closing the connection.
         # Regression test for https://github.com/python/cpython/issues/143198.
         cx = sqlite.connect(":memory:")
@@ -1080,11 +1080,17 @@ def test_executemany_use_after_close(self, params_class):
         cu = cx.cursor()
         msg = r"Cannot operate on a closed database\."
         with self.assertRaisesRegex(sqlite.ProgrammingError, msg):
-            cu.executemany("insert into tmp(a) values (?)", params_class(cx))
+            cu.executemany("insert into tmp(a) values (?)", params_factory(cx))
 
+    # The test constructs an iterable of parameters of length 'n'
+    # and the connection is closed when we access the j-th one.
+    # The iterable is of type 'map' but the test wraps that map
+    # with 'iterable_wrapper' to exercise internals.
     @subTests(("j", "n"), ([0, 1], [0, 3], [1, 3], [2, 3]))
-    @subTests("wtype", (list, lambda x: x))
-    def test_executemany_use_after_close_with_bind_parameters(self, j, n, wtype):
+    @subTests("iterable_wrapper", (list, lambda x: x, lambda x: iter(x)))
+    def test_executemany_use_after_close_with_bind_parameters(
+        self, j, n, iterable_wrapper
+    ):
         # Prevent SIGSEGV when closing the connection while binding parameters.
         #
         # Internally, the connection's state is checked after bind_parameters().
@@ -1110,7 +1116,7 @@ def __len__(self):
 
         cu = cx.cursor()
         msg = r"Cannot operate on a closed database\."
-        items = iter(wtype(map(PT, range(n))))
+        items = iterable_wrapper(map(PT, range(n)))
         with self.assertRaisesRegex(sqlite.ProgrammingError, msg):
             cu.executemany("insert into tmp(a) values (?)", items)
 
@@ -1821,21 +1827,21 @@ def test_connection_executemany(self):
         self.assertEqual(result[0][0], 3, "Basic test of Connection.executemany")
         self.assertEqual(result[1][0], 4, "Basic test of Connection.executemany")
 
-    @subTests("params_class", (ParamsCxCloseInIterMany, ParamsCxCloseInNext))
-    def test_connection_executemany_use_after_close(self, params_class):
+    @subTests("params_factory", (ParamsCxCloseInIterMany, ParamsCxCloseInNext))
+    def test_connection_executemany_use_after_close(self, params_factory):
         # Prevent SIGSEGV with iterable of parameters closing the connection.
         # Regression test for https://github.com/python/cpython/issues/143198.
         cx = sqlite.connect(":memory:")
         cx.execute("create table tmp(a number)")
         self.addCleanup(cx.close)
         msg = r"Cannot operate on a closed database\."
         with self.assertRaisesRegex(sqlite.ProgrammingError, msg):
-            cx.executemany("insert into tmp(a) values (?)", params_class(cx))
+            cx.executemany("insert into tmp(a) values (?)", params_factory(cx))
 
     @subTests(("j", "n"), ([0, 1], [0, 3], [1, 3], [2, 3]))
-    @subTests("wtype", (list, lambda x: x))
+    @subTests("iterable_wrapper", (list, lambda x: x))
     def test_connection_executemany_use_after_close_with_bind_parameters(
-        self, j, n, wtype,
+        self, j, n, iterable_wrapper,
     ):
         # See CursorTests.test_executemany_use_after_close_with_bind_parameters().
 
@@ -1853,7 +1859,7 @@ def __getitem__(self, i):
             def __len__(self):
                 return 1
 
-        items = iter(wtype(map(PT, range(n))))
+        items = iterable_wrapper(map(PT, range(n)))
         msg = r"Cannot operate on a closed database\."
         with self.assertRaisesRegex(sqlite.ProgrammingError, msg):
             cx.executemany("insert into tmp(a) values (?)", items)