Skip to content

Commit 92cc140

Browse files
cleanup
1 parent 8e62fd1 commit 92cc140

File tree

3 files changed

+4
-36
lines changed

3 files changed

+4
-36
lines changed

Include/internal/pycore_opcode_metadata.h

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Tools/cases_generator/analyzer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -982,7 +982,7 @@ def compute_properties(op: parser.CodeDef) -> Properties:
982982
no_save_ip=no_save_ip,
983983
tier=tier_variable(op),
984984
needs_prev=variable_used(op, "prev_instr"),
985-
needs_guard_ip=variable_used(op, "TIER2_STORE_IP") or variable_used(op, "LLTRACE_RESUME_FRAME") or variable_used(op, "DISPATCH_INLINED"),
985+
needs_guard_ip=(unpredictable_jump and "replaced" not in op.annotations) or variable_used(op, "LLTRACE_RESUME_FRAME") or variable_used(op, "DISPATCH_INLINED"),
986986
unpredictable_jump=unpredictable_jump,
987987
)
988988

Tools/cases_generator/tier2_generator.py

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ class Tier2Emitter(Emitter):
6363
def __init__(self, out: CWriter, labels: dict[str, Label]):
6464
super().__init__(out, labels)
6565
self._replacers["oparg"] = self.oparg
66-
self._replacers["JUMPBY"] = self.jumpby
67-
self._replacers["DISPATCH"] = self.dispatch
6866

6967
def goto_error(self, offset: int, storage: Storage) -> str:
7068
# To do: Add jump targets for popping values.
@@ -136,39 +134,6 @@ def oparg(
136134
self.out.emit_at(uop.name[-1], tkn)
137135
return True
138136

139-
def jumpby(
140-
self,
141-
tkn: Token,
142-
tkn_iter: TokenIterator,
143-
uop: CodeSection,
144-
storage: Storage,
145-
inst: Instruction | None,
146-
) -> bool:
147-
if storage.spilled:
148-
raise analysis_error("stack_pointer needs reloading before dispatch", tkn)
149-
storage.stack.flush(self.out)
150-
self.emit("TIER2_STORE_IP")
151-
emit_to(self.out, tkn_iter, "SEMI")
152-
self.emit(";\n")
153-
return True
154-
155-
def dispatch(
156-
self,
157-
tkn: Token,
158-
tkn_iter: TokenIterator,
159-
uop: CodeSection,
160-
storage: Storage,
161-
inst: Instruction | None,
162-
) -> bool:
163-
if storage.spilled:
164-
raise analysis_error("stack_pointer needs reloading before dispatch", tkn)
165-
storage.stack.flush(self.out)
166-
self.emit("break;\n")
167-
next(tkn_iter)
168-
next(tkn_iter)
169-
next(tkn_iter)
170-
return False
171-
172137

173138
def write_uop(uop: Uop, emitter: Emitter, stack: Stack) -> Stack:
174139
locals: dict[str, Local] = {}

0 commit comments

Comments
 (0)