Skip to content

Commit 8ff4a63

Browse files
add comments
1 parent 8f854b8 commit 8ff4a63

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Python/optimizer.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,7 @@ is_terminator(const _PyUOpInstruction *uop)
582582

583583
/* Returns 1 on success (added to trace), 0 on trace end.
584584
*/
585+
// gh-142543: inlining this function causes stack overflows
585586
Py_NO_INLINE int
586587
_PyJit_translate_single_bytecode_to_trace(
587588
PyThreadState *tstate,
@@ -994,6 +995,7 @@ _PyJit_translate_single_bytecode_to_trace(
994995
}
995996

996997
// Returns 0 for do not enter tracing, 1 on enter tracing.
998+
// gh-142543: inlining this function causes stack overflows
997999
Py_NO_INLINE int
9981000
_PyJit_TryInitializeTracing(
9991001
PyThreadState *tstate, _PyInterpreterFrame *frame, _Py_CODEUNIT *curr_instr,
@@ -1066,7 +1068,7 @@ _PyJit_TryInitializeTracing(
10661068
return 1;
10671069
}
10681070

1069-
void
1071+
Py_NO_INLINE void
10701072
_PyJit_FinalizeTracing(PyThreadState *tstate)
10711073
{
10721074
_PyThreadStateImpl *_tstate = (_PyThreadStateImpl *)tstate;

0 commit comments

Comments
 (0)