gh-123465: Ensure PyType_FromMetaclass avoids extra strcmp (GH-125460)

neonene · web-flow · commit 8c9c6d3c1234 · 2024-11-13T17:09:26.000Z
use else
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
@@ -4761,10 +4761,10 @@ PyType_FromMetaclass(
                 if (strcmp(memb->name, "__weaklistoffset__") == 0) {
                     weaklistoffset_member = memb;
                 }
-                if (strcmp(memb->name, "__dictoffset__") == 0) {
+                else if (strcmp(memb->name, "__dictoffset__") == 0) {
                     dictoffset_member = memb;
                 }
-                if (strcmp(memb->name, "__vectorcalloffset__") == 0) {
+                else if (strcmp(memb->name, "__vectorcalloffset__") == 0) {
                     vectorcalloffset_member = memb;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -4761,10 +4761,10 @@ PyType_FromMetaclass(`
`4761`	`4761`	`if (strcmp(memb->name, "__weaklistoffset__") == 0) {`
`4762`	`4762`	`weaklistoffset_member = memb;`
`4763`	`4763`	`}`
`4764`		`- if (strcmp(memb->name, "__dictoffset__") == 0) {`
	`4764`	`+ else if (strcmp(memb->name, "__dictoffset__") == 0) {`
`4765`	`4765`	`dictoffset_member = memb;`
`4766`	`4766`	`}`
`4767`		`- if (strcmp(memb->name, "__vectorcalloffset__") == 0) {`
	`4767`	`+ else if (strcmp(memb->name, "__vectorcalloffset__") == 0) {`
`4768`	`4768`	`vectorcalloffset_member = memb;`
`4769`	`4769`	`}`
`4770`	`4770`	`}`