Use atomics for fetching type flags

mpage · mpage · commit 816e22f17cc1 · 2024-12-18T14:13:24.000-08:00
diff --git a/Python/specialize.c b/Python/specialize.c
@@ -1564,7 +1564,8 @@ specialize_attr_loadclassattr(PyObject *owner, _Py_CODEUNIT *instr,
     }
 #endif
 
-    if (owner_cls->tp_flags & Py_TPFLAGS_INLINE_VALUES) {
+    unsigned long tp_flags = PyType_GetFlags(owner_cls);
+    if (tp_flags & Py_TPFLAGS_INLINE_VALUES) {
 #ifndef Py_GIL_DISABLED
         PyDictKeysObject *keys = ((PyHeapTypeObject *)owner_cls)->ht_cached_keys;
         assert(_PyDictKeys_StringLookup(keys, name) < 0);
@@ -1578,7 +1579,7 @@ specialize_attr_loadclassattr(PyObject *owner, _Py_CODEUNIT *instr,
     }
     else {
         Py_ssize_t dictoffset;
-        if (owner_cls->tp_flags & Py_TPFLAGS_MANAGED_DICT) {
+        if (tp_flags & Py_TPFLAGS_MANAGED_DICT) {
             dictoffset = MANAGED_DICT_OFFSET;
         }
         else {

Original file line number	Diff line number	Diff line change
`@@ -1564,7 +1564,8 @@ specialize_attr_loadclassattr(PyObject owner, _Py_CODEUNIT instr,`
`1564`	`1564`	`}`
`1565`	`1565`	`#endif`
`1566`	`1566`
`1567`		`- if (owner_cls->tp_flags & Py_TPFLAGS_INLINE_VALUES) {`
	`1567`	`+ unsigned long tp_flags = PyType_GetFlags(owner_cls);`
	`1568`	`+ if (tp_flags & Py_TPFLAGS_INLINE_VALUES) {`
`1568`	`1569`	`#ifndef Py_GIL_DISABLED`
`1569`	`1570`	`PyDictKeysObject keys = ((PyHeapTypeObject )owner_cls)->ht_cached_keys;`
`1570`	`1571`	`assert(_PyDictKeys_StringLookup(keys, name) < 0);`
`@@ -1578,7 +1579,7 @@ specialize_attr_loadclassattr(PyObject owner, _Py_CODEUNIT instr,`
`1578`	`1579`	`}`
`1579`	`1580`	`else {`
`1580`	`1581`	`Py_ssize_t dictoffset;`
`1581`		`- if (owner_cls->tp_flags & Py_TPFLAGS_MANAGED_DICT) {`
	`1582`	`+ if (tp_flags & Py_TPFLAGS_MANAGED_DICT) {`
`1582`	`1583`	`dictoffset = MANAGED_DICT_OFFSET;`
`1583`	`1584`	`}`
`1584`	`1585`	`else {`