Change sampling_rate to sample_interval_usec

We are now parsing the interval rather than the frequency.

Author: lkollar

Lib/profiling/sampling/cli.py

@@ -113,7 +113,7 @@ def _build_child_profiler_args(args):
     child_args = []
 
     # Sampling options
-    hz = MICROSECONDS_PER_SECOND // args.sampling_rate
+    hz = MICROSECONDS_PER_SECOND // args.sample_interval_usec
     child_args.extend(["-r", str(hz)])
     child_args.extend(["-d", str(args.duration)])
 
@@ -332,6 +332,7 @@ def _add_sampling_options(parser):
         type=_parse_sampling_rate,
         default="1khz",
         metavar="RATE",
+        dest="sample_interval_usec",
         help="sampling rate (e.g., 10000, 10khz, 10k)",
     )
     sampling_group.add_argument(
@@ -802,7 +803,9 @@ def _handle_attach(args):
     )
 
     # Create the appropriate collector
-    collector = _create_collector(args.format, args.sampling_rate, skip_idle, args.opcodes)
+    collector = _create_collector(
+        args.format, args.sample_interval_usec, skip_idle, args.opcodes
+    )
 
     with _get_child_monitor_context(args, args.pid):
         collector = sample(
@@ -871,7 +874,9 @@ def _handle_run(args):
     )
 
     # Create the appropriate collector
-    collector = _create_collector(args.format, args.sampling_rate, skip_idle, args.opcodes)
+    collector = _create_collector(
+        args.format, args.sample_interval_usec, skip_idle, args.opcodes
+    )
 
     with _get_child_monitor_context(args, process.pid):
         try:
@@ -909,7 +914,7 @@ def _handle_live_attach(args, pid):
 
     # Create live collector with default settings
     collector = LiveStatsCollector(
-        args.sampling_rate,
+        args.sample_interval_usec,
         skip_idle=skip_idle,
         sort_by="tottime",  # Default initial sort
         limit=20,  # Default limit
@@ -955,7 +960,7 @@ def _handle_live_run(args):
 
     # Create live collector with default settings
     collector = LiveStatsCollector(
-        args.sampling_rate,
+        args.sample_interval_usec,
         skip_idle=skip_idle,
         sort_by="tottime",  # Default initial sort
         limit=20,  # Default limit

Lib/test/test_profiling/test_sampling_profiler/test_children.py

@@ -384,7 +384,7 @@ def test_build_child_profiler_args(self):
         from profiling.sampling.cli import _build_child_profiler_args
 
         args = argparse.Namespace(
-            sampling_rate=200,
+            sample_interval_usec=200,
             duration=15,
             all_threads=True,
             realtime_stats=False,
@@ -442,7 +442,7 @@ def test_build_child_profiler_args_no_gc(self):
         from profiling.sampling.cli import _build_child_profiler_args
 
         args = argparse.Namespace(
-            sampling_rate=100,
+            sample_interval_usec=100,
             duration=5,
             all_threads=False,
             realtime_stats=False,
@@ -508,7 +508,7 @@ def test_setup_child_monitor(self):
         from profiling.sampling.cli import _setup_child_monitor
 
         args = argparse.Namespace(
-            sampling_rate=100,
+            sample_interval_usec=100,
             duration=5,
             all_threads=False,
             realtime_stats=False,