Skip to content

Commit 7b4f82e

Browse files
Refactor _Py_stackref_get_borrowed_from
1 parent 9124366 commit 7b4f82e

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

Include/internal/pycore_stackref.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ PyAPI_FUNC(PyObject *) _Py_stackref_get_object(_PyStackRef ref);
6363
PyAPI_FUNC(PyObject *) _Py_stackref_close(_PyStackRef ref, const char *filename, int linenumber);
6464
PyAPI_FUNC(_PyStackRef) _Py_stackref_create(PyObject *obj, uint16_t flags, const char *filename, int linenumber);
6565
PyAPI_FUNC(void) _Py_stackref_record_borrow(_PyStackRef ref, const char *filename, int linenumber);
66-
PyAPI_FUNC(void) _Py_stackref_get_borrowed_from(_PyStackRef ref, _PyStackRef *p_borrowed_from, const char *filename, int linenumber);
66+
PyAPI_FUNC(_PyStackRef) _Py_stackref_get_borrowed_from(_PyStackRef ref, const char *filename, int linenumber);
6767
PyAPI_FUNC(void) _Py_stackref_set_borrowed_from(_PyStackRef ref, _PyStackRef borrowed_from, const char *filename, int linenumber);
6868
extern void _Py_stackref_associate(PyInterpreterState *interp, PyObject *obj, _PyStackRef ref);
6969

@@ -252,8 +252,7 @@ _PyStackRef_DUP(_PyStackRef ref, const char *filename, int linenumber)
252252
}
253253
_PyStackRef new_ref = _Py_stackref_create(obj, flags, filename, linenumber);
254254
if (flags == Py_TAG_REFCNT && !_Py_IsImmortal(obj)) {
255-
_PyStackRef borrowed_from;
256-
_Py_stackref_get_borrowed_from(ref, &borrowed_from, filename, linenumber);
255+
_PyStackRef borrowed_from = _Py_stackref_get_borrowed_from(ref, filename, linenumber);
257256
_Py_stackref_set_borrowed_from(new_ref, borrowed_from, filename, linenumber);
258257
}
259258
return new_ref;

Python/stackrefs.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,8 @@ _Py_stackref_record_borrow(_PyStackRef ref, const char *filename, int linenumber
180180
entry->linenumber_borrow = linenumber;
181181
}
182182

183-
void
184-
_Py_stackref_get_borrowed_from(_PyStackRef ref, _PyStackRef *p_borrowed_from, const char *filename, int linenumber)
183+
_PyStackRef
184+
_Py_stackref_get_borrowed_from(_PyStackRef ref, const char *filename, int linenumber)
185185
{
186186
assert(!PyStackRef_IsError(ref));
187187
PyInterpreterState *interp = PyInterpreterState_Get();
@@ -193,9 +193,7 @@ _Py_stackref_get_borrowed_from(_PyStackRef ref, _PyStackRef *p_borrowed_from, co
193193
ref.index, filename, linenumber);
194194
}
195195

196-
if (p_borrowed_from != NULL) {
197-
*p_borrowed_from = entry->borrowed_from;
198-
}
196+
return entry->borrowed_from;
199197
}
200198

201199
// This function should be used no more than once per ref.

0 commit comments

Comments
 (0)