Fix pyframe copy

Author: mpage

Include/internal/pycore_frame.h

@@ -153,8 +153,8 @@ static inline void _PyFrame_Copy(_PyInterpreterFrame *src, _PyInterpreterFrame *
     int stacktop = (int)(src->stackpointer - src->localsplus);
     assert(stacktop >= _PyFrame_GetCode(src)->co_nlocalsplus);
     dest->stackpointer = dest->localsplus + stacktop;
-    for (int i = 1; i < stacktop; i++) {
-        dest->localsplus[i] = src->localsplus[i];
+    for (int i = 0; i < stacktop; i++) {
+        dest->localsplus[i] = _PyStackRef_StealIfUnborrowed(src->localsplus[i]);
     }
     // Don't leave a dangling pointer to the old frame when creating generators
     // and coroutines:

Include/internal/pycore_opcode_metadata.h

@@ -225,7 +225,6 @@ _PyStackRef_StealIfUnborrowed(_PyStackRef stackref)
             return stackref;
         }
         else {
-            fprintf(stderr, "===> Converting to strong reference\n");
             return (_PyStackRef){ .bits = (uintptr_t)(Py_NewRef(obj)) | Py_TAG_PTR };
         }
     }

Include/internal/pycore_stackref.h

@@ -542,6 +542,7 @@ init_code(PyCodeObject *co, struct _PyCodeConstructor *con)
     }
     co->_co_firsttraceable = entry_point;
 #ifdef Py_GIL_DISABLED
+    // fprintf(stderr, "== Quicken %s\n", PyUnicode_AsUTF8(co->co_qualname));
     _PyCode_Quicken(_PyCode_CODE(co), Py_SIZE(co), interp->config.tlbc_enabled);
 #else
     _PyCode_Quicken(_PyCode_CODE(co), Py_SIZE(co), 1);

Include/internal/pycore_uop_metadata.h

@@ -271,7 +271,7 @@ dummy_func(
         }
 
         inst (LOAD_FAST_BORROW, (-- value)) {
-            value = PyStackRef_DupDeferred(value);
+            value = PyStackRef_DupDeferred(GETLOCAL(oparg));
         }
 
         inst(LOAD_FAST_AND_CLEAR, (-- value)) {
@@ -750,7 +750,7 @@ dummy_func(
              * only the locals reference, so PyUnicode_Append knows
              * that the string is safe to mutate.
              */
-            assert(Py_REFCNT(left_o) >= 2);
+            // assert(Py_REFCNT(left_o) >= 2);
             PyStackRef_CLOSE_SPECIALIZED(left, _PyUnicode_ExactDealloc);
             DEAD(left);
             PyObject *temp = PyStackRef_AsPyObjectSteal(*target_local);
@@ -1096,7 +1096,7 @@ dummy_func(
         // is pushed to a different frame, the callers' frame.
         inst(RETURN_VALUE, (retval -- res)) {
             assert(frame->owner != FRAME_OWNED_BY_INTERPRETER);
-            _PyStackRef temp = retval;
+            _PyStackRef temp = _PyStackRef_StealIfUnborrowed(retval);
             DEAD(retval);
             SAVE_STACK();
             assert(EMPTY());