address review: rename _PyLong_IsImmortal -> _PyLong_HasImmortalTag

Author: skirpichev

Include/internal/pycore_long.h

@@ -232,7 +232,7 @@ _PyLong_IsPositive(const PyLongObject *op)
 }
 
 static inline bool
-_PyLong_IsImmortal(const PyLongObject *op)
+_PyLong_HasImmortalTag(const PyLongObject *op)
 {
     assert(PyLong_Check(op));
     bool is_small_int = (op->long_value.lv_tag & IMMORTALITY_BIT_MASK) != 0;
@@ -303,7 +303,7 @@ _PyLong_SetDigitCount(PyLongObject *op, Py_ssize_t size)
 static inline void
 _PyLong_FlipSign(PyLongObject *op)
 {
-    assert(!_PyLong_IsImmortal(op));
+    assert(!_PyLong_HasImmortalTag(op));
     unsigned int flipped_sign = 2 - (op->long_value.lv_tag & SIGN_MASK);
     op->long_value.lv_tag &= NON_SIZE_MASK;
     op->long_value.lv_tag |= flipped_sign;

Modules/_testcapi/immortal.c

@@ -31,13 +31,13 @@ test_immortal_small_ints(PyObject *self, PyObject *Py_UNUSED(ignored))
     for (int i = -5; i <= 1024; i++) {
         PyObject *obj = PyLong_FromLong(i);
         assert(verify_immortality(obj));
-        int has_int_immortal_bit = _PyLong_IsImmortal((PyLongObject *)obj);
+        int has_int_immortal_bit = _PyLong_HasImmortalTag((PyLongObject *)obj);
         assert(has_int_immortal_bit);
     }
     for (int i = 1025; i <= 1030; i++) {
         PyObject *obj = PyLong_FromLong(i);
         assert(obj);
-        int has_int_immortal_bit = _PyLong_IsImmortal((PyLongObject *)obj);
+        int has_int_immortal_bit = _PyLong_HasImmortalTag((PyLongObject *)obj);
         assert(!has_int_immortal_bit);
         Py_DECREF(obj);
     }

Objects/longobject.c

@@ -3626,7 +3626,7 @@ void
 _PyLong_ExactDealloc(PyObject *self)
 {
     assert(PyLong_CheckExact(self));
-    if (_PyLong_IsImmortal((PyLongObject *)self)) {
+    if (_PyLong_HasImmortalTag((PyLongObject *)self)) {
         // See PEP 683, section Accidental De-Immortalizing for details
         _Py_SetImmortal(self);
         return;
@@ -3641,7 +3641,7 @@ _PyLong_ExactDealloc(PyObject *self)
 static void
 long_dealloc(PyObject *self)
 {
-    if (_PyLong_IsImmortal((PyLongObject *)self)) {
+    if (_PyLong_HasImmortalTag((PyLongObject *)self)) {
         /* This should never get called, but we also don't want to SEGV if
          * we accidentally decref small Ints out of existence. Instead,
          * since small Ints are immortal, re-set the reference count.