Skip to content

Commit 75f4265

Browse files
committed
Drop test_smtplib tests again
There are already other tests for the functionality, therefore there is no need to test implementation details.
1 parent 5ea81fc commit 75f4265

File tree

1 file changed

+0
-28
lines changed

1 file changed

+0
-28
lines changed

Lib/test/test_smtplib.py

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -282,34 +282,6 @@ def testBasic(self):
282282
# connect
283283
smtp = smtplib.SMTP(HOST, self.port, local_hostname='localhost',
284284
timeout=support.LOOPBACK_TIMEOUT)
285-
# implicit .connect must set ._host since it is used by .starttls
286-
self.assertEqual(smtp._host, HOST)
287-
smtp.quit()
288-
289-
def test_host_port_host(self):
290-
# create instance with host:port notation
291-
smtp = smtplib.SMTP(f"{HOST}:{self.port}", local_hostname='localhost',
292-
timeout=support.LOOPBACK_TIMEOUT)
293-
# implicit .connect must set ._host since it is used by .starttls
294-
self.assertEqual(smtp._host, HOST)
295-
smtp.quit()
296-
297-
def test_explicit_connect(self):
298-
# create instance without arguments
299-
smtp = smtplib.SMTP(local_hostname='localhost',
300-
timeout=support.LOOPBACK_TIMEOUT)
301-
# explicit .connect must set ._host since it is used by .starttls
302-
smtp.connect(HOST, self.port)
303-
self.assertEqual(smtp._host, HOST)
304-
smtp.quit()
305-
306-
def test_explicit_connect_host_port(self):
307-
# create instance without arguments
308-
smtp = smtplib.SMTP(local_hostname='localhost',
309-
timeout=support.LOOPBACK_TIMEOUT)
310-
# explicit .connect with host:port notation must set ._host, too
311-
smtp.connect(f"{HOST}:{self.port}")
312-
self.assertEqual(smtp._host, HOST)
313285
smtp.quit()
314286

315287
def testSourceAddress(self):

0 commit comments

Comments
 (0)