Skip to content

Commit 740db90

Browse files
b9788213sobolevn
andauthored
[3.13] gh-143866: Verify return value of pathlib.write_{bytes,text} methods in tests (GH-143870) (#144078)
(cherry picked from commit cb6a662) Co-authored-by: sobolevn <mail@sobolevn.me>
1 parent 77dddec commit 740db90

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

Lib/test/test_pathlib/test_pathlib_abc.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1630,20 +1630,22 @@ def test_open_common(self):
16301630

16311631
def test_read_write_bytes(self):
16321632
p = self.cls(self.base)
1633-
(p / 'fileA').write_bytes(b'abcdefg')
1634-
self.assertEqual((p / 'fileA').read_bytes(), b'abcdefg')
1633+
data = b'abcdefg'
1634+
self.assertEqual(len(data), (p / 'fileA').write_bytes(data))
1635+
self.assertEqual((p / 'fileA').read_bytes(), data)
16351636
# Check that trying to write str does not truncate the file.
16361637
self.assertRaises(TypeError, (p / 'fileA').write_bytes, 'somestr')
1637-
self.assertEqual((p / 'fileA').read_bytes(), b'abcdefg')
1638+
self.assertEqual((p / 'fileA').read_bytes(), data)
16381639

16391640
def test_read_write_text(self):
16401641
p = self.cls(self.base)
1641-
(p / 'fileA').write_text('äbcdefg', encoding='latin-1')
1642+
data = 'äbcdefg'
1643+
self.assertEqual(len(data), (p / 'fileA').write_text(data, encoding='latin-1'))
16421644
self.assertEqual((p / 'fileA').read_text(
16431645
encoding='utf-8', errors='ignore'), 'bcdefg')
16441646
# Check that trying to write bytes does not truncate the file.
16451647
self.assertRaises(TypeError, (p / 'fileA').write_text, b'somebytes')
1646-
self.assertEqual((p / 'fileA').read_text(encoding='latin-1'), 'äbcdefg')
1648+
self.assertEqual((p / 'fileA').read_text(encoding='latin-1'), data)
16471649

16481650
def test_read_text_with_newlines(self):
16491651
p = self.cls(self.base)

0 commit comments

Comments
 (0)