gh-130050: Fix memory leaks in _testexternalinspection (#130051)

sergey-miryanov · web-flow · commit 633853004c5b · 2025-02-12T21:12:07.000Z
diff --git a/Modules/_testexternalinspection.c b/Modules/_testexternalinspection.c
@@ -778,6 +778,7 @@ parse_coro_chain(
     }
 
     if (PyList_Append(render_to, name)) {
+        Py_DECREF(name);
         return -1;
     }
     Py_DECREF(name);
@@ -955,7 +956,6 @@ parse_task(
     if (PyList_Append(render_to, result)) {
         goto err;
     }
-    Py_DECREF(result);
 
     PyObject *awaited_by = PyList_New(0);
     if (awaited_by == NULL) {
@@ -973,6 +973,7 @@ parse_task(
     ) {
         goto err;
     }
+    Py_DECREF(result);
 
     return 0;
 
@@ -1527,6 +1528,7 @@ get_async_stack_trace(PyObject* self, PyObject* args)
     }
     PyObject* calls = PyList_New(0);
     if (calls == NULL) {
+        Py_DECREF(result);
         return NULL;
     }
     if (PyList_SetItem(result, 0, calls)) { /* steals ref to 'calls' */

Original file line number	Diff line number	Diff line change
`@@ -778,6 +778,7 @@ parse_coro_chain(`
`778`	`778`	`}`
`779`	`779`
`780`	`780`	`if (PyList_Append(render_to, name)) {`
	`781`	`+ Py_DECREF(name);`
`781`	`782`	`return -1;`
`782`	`783`	`}`
`783`	`784`	`Py_DECREF(name);`
`@@ -955,7 +956,6 @@ parse_task(`
`955`	`956`	`if (PyList_Append(render_to, result)) {`
`956`	`957`	`goto err;`
`957`	`958`	`}`
`958`		`- Py_DECREF(result);`
`959`	`959`
`960`	`960`	`PyObject *awaited_by = PyList_New(0);`
`961`	`961`	`if (awaited_by == NULL) {`
`@@ -973,6 +973,7 @@ parse_task(`
`973`	`973`	`) {`
`974`	`974`	`goto err;`
`975`	`975`	`}`
	`976`	`+ Py_DECREF(result);`
`976`	`977`
`977`	`978`	`return 0;`
`978`	`979`
`@@ -1527,6 +1528,7 @@ get_async_stack_trace(PyObject* self, PyObject* args)`
`1527`	`1528`	`}`
`1528`	`1529`	`PyObject* calls = PyList_New(0);`
`1529`	`1530`	`if (calls == NULL) {`
	`1531`	`+ Py_DECREF(result);`
`1530`	`1532`	`return NULL;`
`1531`	`1533`	`}`
`1532`	`1534`	`if (PyList_SetItem(result, 0, calls)) { /* steals ref to 'calls' */`