Skip to content

Commit 5e05ff4

Browse files
committed
Remove magic number in test and update deprecated message
1 parent 195511f commit 5e05ff4

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

Lib/test/test_winreg.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -275,15 +275,14 @@ def test_registry_works_with_options(self):
275275
reserved=REG_OPTION_VOLATILE)
276276
self._read_test_data(HKEY_CURRENT_USER, OpenKey=ok)
277277

278-
# TypeError cases
279278
with self.assertRaises(TypeError):
280279
OpenKeyEx(HKEY_CURRENT_USER, test_key_name, 0, KEY_READ, 0)
281280
with self.assertRaises(TypeError):
282281
OpenKeyEx(HKEY_CURRENT_USER, test_key_name, 0, KEY_READ, options=0)
283282
with self.assertRaises(TypeError):
284-
OpenKeyEx(HKEY_CURRENT_USER, test_key_name, 1, KEY_READ, reserved=1)
283+
OpenKeyEx(HKEY_CURRENT_USER, test_key_name, REG_OPTION_VOLATILE, KEY_READ, reserved=REG_OPTION_VOLATILE)
285284
with self.assertRaises(TypeError):
286-
OpenKeyEx(HKEY_CURRENT_USER, test_key_name, options=1, reserved=1)
285+
OpenKeyEx(HKEY_CURRENT_USER, test_key_name, options=REG_OPTION_VOLATILE, reserved=REG_OPTION_VOLATILE)
287286

288287
self._delete_test_data(HKEY_CURRENT_USER)
289288

PC/winreg.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1451,7 +1451,7 @@ winreg_OpenKeyEx_impl(PyObject *module, HKEY key, const wchar_t *sub_key,
14511451
}
14521452
if (reserved != 0) {
14531453
if (PyErr_WarnEx(PyExc_DeprecationWarning,
1454-
"reserved is deprecated, use options instead.", 1))
1454+
"reserved is deprecated, use OpenKeyEx with options parameter instead.", 1))
14551455
{
14561456
return NULL;
14571457
}

0 commit comments

Comments
 (0)