Skip to content

Commit 55f149c

Browse files
committed
Address code review
1 parent af7326b commit 55f149c

File tree

2 files changed

+12
-24
lines changed

2 files changed

+12
-24
lines changed

Python/optimizer_bytecodes.c

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1356,24 +1356,18 @@ dummy_func(void) {
13561356
}
13571357

13581358
op(_GUARD_NOS_ANY_DICT, (nos, unused -- nos, unused)) {
1359-
if (sym_matches_type(nos, &PyDict_Type)) {
1360-
ADD_OP(_NOP, 0, 0);
1361-
sym_set_type(nos, &PyDict_Type);
1362-
}
1363-
else if (sym_matches_type(nos, &PyFrozenDict_Type)) {
1359+
PyTypeObject *tp = sym_get_type(nos);
1360+
if (tp == &PyDict_Type || tp == &PyFrozenDict_Type) {
13641361
ADD_OP(_NOP, 0, 0);
1365-
sym_set_type(nos, &PyFrozenDict_Type);
1362+
sym_set_type(nos, tp);
13661363
}
13671364
}
13681365

13691366
op(_GUARD_TOS_ANY_DICT, (tos -- tos)) {
1370-
if (sym_matches_type(tos, &PyDict_Type)) {
1371-
ADD_OP(_NOP, 0, 0);
1372-
sym_set_type(tos, &PyDict_Type);
1373-
}
1374-
else if (sym_matches_type(tos, &PyFrozenDict_Type)) {
1367+
PyTypeObject *tp = sym_get_type(tos);
1368+
if (tp == &PyDict_Type || tp == &PyFrozenDict_Type) {
13751369
ADD_OP(_NOP, 0, 0);
1376-
sym_set_type(tos, &PyFrozenDict_Type);
1370+
sym_set_type(tos, tp);
13771371
}
13781372
}
13791373

Python/optimizer_cases.c.h

Lines changed: 6 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)