Skip to content

Commit 4edc254

Browse files
committed
gh-134584 Address review-comments.
1 parent 9b93ce5 commit 4edc254

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

Python/bytecodes.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1069,11 +1069,13 @@ dummy_func(
10691069
if (rc == 0) {
10701070
_PyErr_SetKeyError(sub);
10711071
}
1072-
INPUTS_DEAD();
1073-
ERROR_IF(rc <= 0); // not found or error
1072+
if (rc <= 0) {
1073+
ERROR_NO_POP();
1074+
}
10741075
res = PyStackRef_FromPyObjectSteal(res_o);
10751076
ds = dict_st;
10761077
ss = sub_st;
1078+
INPUTS_DEAD();
10771079
}
10781080

10791081
op(_BINARY_OP_SUBSCR_CHECK_FUNC, (container, unused -- container, unused, getitem)) {

Python/executor_cases.c.h

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/generated_cases.c.h

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/optimizer_bytecodes.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,6 @@ dummy_func(void) {
384384
res = sym_new_not_null(ctx);
385385
ds = dict_st;
386386
ss = sub_st;
387-
INPUTS_DEAD();
388387
}
389388

390389
op(_TO_BOOL, (value -- res)) {

0 commit comments

Comments
 (0)