do not replace const ops

Author: noamcohen97

Lib/test/test_capi/test_opt.py

@@ -2234,21 +2234,6 @@ def testfunc(n):
         self.assertNotIn("_GUARD_TOS_INT", uops)
         self.assertNotIn("_GUARD_NOS_INT", uops)
 
-    def test_unary_invert_replace(self):
-        def testfunc(n):
-            for _ in range(n):
-                a = -1
-                a = ~a
-
-        testfunc(TIER2_THRESHOLD)
-
-        ex = get_first_executor(testfunc)
-        self.assertIsNotNone(ex)
-        uops = get_opnames(ex)
-
-        self.assertNotIn("_UNARY_INVERT", uops)
-        self.assertIn("_LOAD_CONST_INLINE_BORROW", uops)
-
 
 def global_identity(x):
     return x

Python/optimizer_bytecodes.c

@@ -468,22 +468,11 @@ dummy_func(void) {
     }
 
     op(_UNARY_INVERT, (value -- res)) {
-        if (sym_is_const(ctx, value)) {
-            PyObject *temp = PyNumber_Invert(sym_get_const(ctx, value));
-            if (temp == NULL) {
-                goto error;
-            }
-            if (_Py_IsImmortal(temp)) {
-                REPLACE_OP(this_instr, _POP_TOP_LOAD_CONST_INLINE_BORROW, 0, (uintptr_t)temp);
-            }
-            res = sym_new_const(ctx, temp);
-            Py_DECREF(temp);
-        } else {
-            if (sym_matches_type(value, &PyLong_Type) || sym_matches_type(value, &PyBool_Type)) {
-                res = sym_new_type(ctx, &PyLong_Type);
-            } else {
-                res = sym_new_not_null(ctx);
-            }
+        if (sym_matches_type(value, &PyLong_Type) || sym_matches_type(value, &PyBool_Type)) {
+            res = sym_new_type(ctx, &PyLong_Type);
+        }
+        else {
+            res = sym_new_not_null(ctx);
         }
     }