Review

Author: StanFromIreland

.github/workflows/build.yml

@@ -54,6 +54,8 @@ jobs:
     needs: [build-context, check-docs]
     if: fromJSON(needs.build-context.outputs.run-idle-help-doc)
     uses: ./.github/workflows/reusable-idle-help-doc.yml
+    with:
+      idle-html-artifact-id: ${{ needs.check-docs.outputs.idle-html-artifact-id }}
 
   check-autoconf-regen:
     name: 'Check if Autoconf files are up to date'
@@ -719,14 +721,7 @@ jobs:
           cifuzz,
           check-idle-help-doc,
         allowed-skips: >-
-          ${{
-            !fromJSON(needs.build-context.outputs.run-docs)
-            && '
-            check-docs,
-            check-idle-help-doc,
-            '
-            || ''
-          }}
+          ${{ !fromJSON(needs.build-context.outputs.run-docs) && 'check-docs,' || '' }}
           ${{
             needs.build-context.outputs.run-tests != 'true'
             && '

.github/workflows/reusable-docs.yml

@@ -2,6 +2,10 @@ name: Reusable Docs
 
 on:
   workflow_call:
+    outputs:
+      idle-html-artifact-id:
+        description: 'Artifact ID for the built idle.html'
+        value: ${{ jobs.build-doc.outputs.idle-html-artifact-id }}
   workflow_dispatch:
 
 permissions:
@@ -19,6 +23,8 @@ jobs:
     name: 'Docs'
     runs-on: ubuntu-latest
     timeout-minutes: 60
+    outputs:
+      idle-html-artifact-id: ${{ steps.upload-idle-html.outputs.artifact-id }}
     env:
       branch_base: 'origin/${{ github.event.pull_request.base.ref }}'
       branch_pr: 'origin/${{ github.event.pull_request.head.ref }}'
@@ -76,6 +82,7 @@ jobs:
           --fail-if-improved \
           --fail-if-new-news-nit
     - name: 'Upload built idle.html'
+      id: upload-idle-html
       uses: actions/upload-artifact@v4
       with:
         name: idle-html

.github/workflows/reusable-idle-help-doc.yml

@@ -2,6 +2,11 @@ name: Reusable check IDLE help
 
 on:
   workflow_call:
+    inputs:
+      idle-html-artifact-id:
+        description: 'Artifact ID for the built idle.html'
+        required: true
+        type: string
 
 permissions: {}
 
@@ -20,16 +25,14 @@ jobs:
     - name: 'Download built idle.html'
       uses: actions/download-artifact@v7
       with:
-        name: idle-html
+        artifact-ids: ${{ inputs.idle-html-artifact-id }}
         path: Doc/build/html/library
     - name: 'Set up Python'
       uses: actions/setup-python@v6
       with:
         python-version: '3'
     - name: 'Regenerate Lib/idlelib/help.html'
-      run: |
-        mkdir -v html/  # trick make into skipping the dependency target
-        make idlehelp
+      run: make idlehelp
       working-directory: Doc
     - name: 'Check for changes'
       run: |

Doc/Makefile

@@ -145,7 +145,7 @@ pydoc-topics: build
 	      "&& cp build/pydoc-topics/module_docs.py ../Lib/pydoc_data/module_docs.py"
 
 .PHONY: idlehelp
-idlehelp: html
+idlehelp: build/html/library/idle.html
 	$(PYTHON) ../Tools/build/generate_idle_help.py
 
 .PHONY: gettext