Skip to content

Commit 4169b46

Browse files
committed
Simplify
1 parent 4c0a7a4 commit 4169b46

File tree

1 file changed

+9
-13
lines changed

1 file changed

+9
-13
lines changed

Tools/build/compute-changes.py

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -102,34 +102,30 @@ def process_changed_files(changed_files: Set[Path]) -> Outputs:
102102
run_windows_msi = False
103103

104104
for file in changed_files:
105-
file_name = file.name
106-
file_suffix = file.suffix
107-
file_parts = file.parts
108-
109105
# Documentation files
110-
doc_or_misc = file_parts[0] in {"Doc", "Misc"}
111-
doc_file = file_suffix in SUFFIXES_DOCUMENTATION or doc_or_misc
106+
doc_or_misc = file.parts[0] in {"Doc", "Misc"}
107+
doc_file = file.suffix in SUFFIXES_DOCUMENTATION or doc_or_misc
112108

113109
if file.parent == GITHUB_WORKFLOWS_PATH:
114-
if file_name == "build.yml":
110+
if file.name == "build.yml":
115111
run_tests = run_ci_fuzz = True
116-
if file_name == "reusable-docs.yml":
112+
if file.name == "reusable-docs.yml":
117113
run_docs = True
118-
if file_name == "reusable-windows-msi.yml":
114+
if file.name == "reusable-windows-msi.yml":
119115
run_windows_msi = True
120116

121117
if not (
122118
doc_file
123119
or file == GITHUB_CODEOWNERS_PATH
124-
or file_name in CONFIGURATION_FILE_NAMES
120+
or file.name in CONFIGURATION_FILE_NAMES
125121
):
126122
run_tests = True
127123

128124
# The fuzz tests are pretty slow so they are executed only for PRs
129125
# changing relevant files.
130-
if file_suffix in SUFFIXES_C_OR_CPP:
126+
if file.suffix in SUFFIXES_C_OR_CPP:
131127
run_ci_fuzz = True
132-
if file_parts[:2] in {
128+
if file.parts[:2] in {
133129
("configure",),
134130
("Modules", "_xxtestfuzz"),
135131
}:
@@ -140,7 +136,7 @@ def process_changed_files(changed_files: Set[Path]) -> Outputs:
140136
run_docs = True
141137

142138
# Check for changed MSI installer-related files
143-
if file_parts[:2] == ("Tools", "msi"):
139+
if file.parts[:2] == ("Tools", "msi"):
144140
run_windows_msi = True
145141

146142
return Outputs(

0 commit comments

Comments
 (0)