Skip to content

Commit 3e93acc

Browse files
Fix urlretrieve reporthook to report actual bytes read
1 parent 8b669d5 commit 3e93acc

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Lib/test/test_urllib.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -727,7 +727,7 @@ def hooktester(block_count, block_read_size, file_size, _report=report):
727727
self.assertEqual(report[0][2], 8193)
728728
self.assertEqual(report[0][1], 8192)
729729
self.assertEqual(report[1][1], 8192)
730-
self.assertEqual(report[2][1], 8192)
730+
self.assertEqual(report[2][1], 1) # last block only reads 1 byte
731731

732732

733733
class urlretrieve_HttpTests(unittest.TestCase, FakeHTTPMixin):

Lib/urllib/request.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ def urlretrieve(url, filename=None, reporthook=None, data=None):
242242
tfp.write(block)
243243
blocknum += 1
244244
if reporthook:
245-
reporthook(blocknum, bs, size)
245+
reporthook(blocknum, len(block), size)
246246

247247
if size >= 0 and read < size:
248248
raise ContentTooShortError(

0 commit comments

Comments
 (0)