Commit 3c28ed6
Remove obsolete XXX comment about non-blocking I/O
The comment suggested rewriting Popen._communicate() to use
non-blocking I/O on file objects now that Python 3's io module
is used instead of C stdio.
This is unnecessary - the current approach using select() to
detect ready fds followed by os.read()/os.write() is correct
and efficient. The selector already solves "when is data ready?"
so non-blocking mode would add complexity with no benefit.
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>1 parent a3e98a7 commit 3c28ed6
1 file changed
+0
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2655 | 2655 | | |
2656 | 2656 | | |
2657 | 2657 | | |
2658 | | - | |
2659 | | - | |
2660 | | - | |
2661 | 2658 | | |
2662 | 2659 | | |
2663 | 2660 | | |
| |||
0 commit comments