Skip to content

Commit 2c12e92

Browse files
committed
Address review
1 parent 9ef7a2b commit 2c12e92

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Objects/listobject.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -447,6 +447,7 @@ static int
447447
ins1(PyListObject *self, Py_ssize_t where, PyObject *v)
448448
{
449449
Py_ssize_t i, n = Py_SIZE(self);
450+
PyObject **items;
450451
if (v == NULL) {
451452
PyErr_BadInternalCall();
452453
return -1;
@@ -463,9 +464,10 @@ ins1(PyListObject *self, Py_ssize_t where, PyObject *v)
463464
}
464465
if (where > n)
465466
where = n;
467+
items = self->ob_item;
466468
for (i = n; --i >= where; )
467-
FT_ATOMIC_STORE_PTR_RELEASE(self->ob_item[i+1], self->ob_item[i]);
468-
FT_ATOMIC_STORE_PTR_RELEASE(self->ob_item[where], Py_NewRef(v));
469+
FT_ATOMIC_STORE_PTR_RELAXED(items[i+1], items[i]);
470+
FT_ATOMIC_STORE_PTR_RELEASE(items[where], Py_NewRef(v));
469471
return 0;
470472
}
471473

0 commit comments

Comments
 (0)