Skip to content

Commit 2632c42

Browse files
committed
score edits
1 parent 4a8289d commit 2632c42

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

Lib/difflib.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2714,7 +2714,7 @@ def _calc_candidate_score(block0, block1, block2):
27142714
total = ∑ length^p
27152715
where p is such that c^p == (0.9c)^p + (0.2c)^p
27162716
2717-
If only 1 block found, it is a definite score.
2717+
If only 1 block found, it is a definitive score.
27182718
Otherwise, it gets bonus for each additional block
27192719
as it has poential to recurse further to each side
27202720
"""
@@ -2731,7 +2731,9 @@ def _calc_candidate_score(block0, block1, block2):
27312731
total = sum(k**_BALANCE_SCORE_POWER for k in lengths)
27322732
nk = len(lengths)
27332733
if nk > 1:
2734-
total += (nk - 1) * min(lengths) / 3
2734+
min_len = min(lengths)
2735+
ratio = min(1 / 2, min_len / max(lengths))
2736+
total += (nk - 1) * min_len * ratio
27352737
return total
27362738

27372739

Lib/test/test_difflib.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -663,18 +663,6 @@ def test_find_with_junk(self):
663663
result = difflib._LCSUBAutomaton(seq2, junk=('_')).find(seq1)
664664
self.assertEqual(result, expect)
665665

666-
def test_findall(self):
667-
seq1 = 'defabc'
668-
aut = difflib._LCSUBAutomaton('abcdef')
669-
result = [seq1[i:i+k] for i, j, k in aut.findall(seq1)]
670-
self.assertEqual(result, ['d', 'de', 'def', 'a', 'ab', 'abc'])
671-
result = [seq1[i:i+k] for i, j, k in aut.findall(seq1, maximal=True)]
672-
self.assertEqual(result, ['def', 'abc'])
673-
result = [seq1[i:i+k] for i, j, k in aut.findall(seq1, mink=2)]
674-
self.assertEqual(result, ['de', 'def', 'ab', 'abc'])
675-
result = [seq1[i:i+k] for i, j, k in aut.findall(seq1, maxk=2)]
676-
self.assertEqual(result, ['d', 'de', 'a', 'ab'])
677-
678666
def test_batchfind(self):
679667
seq1 = 'fgfedabacba'
680668
seq2 = seq1[::-1]

0 commit comments

Comments
 (0)