code review

Author: kumaraditya303

Python/tracemalloc.c

@@ -1213,14 +1213,16 @@ PyTraceMalloc_Track(unsigned int domain, uintptr_t ptr,
     }
     PyGILState_STATE gil_state = PyGILState_Ensure();
     TABLES_LOCK();
-    // Check again now that we hold the lock
-    if (!tracemalloc_config.tracing) {
-        TABLES_UNLOCK();
-        PyGILState_Release(gil_state);
+
+    int result;
+    if (tracemalloc_config.tracing) {
+        result = tracemalloc_add_trace_unlocked(domain, ptr, size);
+    }
+    else {
         /* tracemalloc is not tracing: do nothing */
-        return -2;
+        result = -2;
     }
-    int result = tracemalloc_add_trace_unlocked(domain, ptr, size);
+
     TABLES_UNLOCK();
     PyGILState_Release(gil_state);
     return result;
@@ -1236,15 +1238,19 @@ PyTraceMalloc_Untrack(unsigned int domain, uintptr_t ptr)
     }
 
     TABLES_LOCK();
-    // Check again now that we hold the lock
-    if (!tracemalloc_config.tracing) {
-        TABLES_UNLOCK();
+
+    int result;
+    if (tracemalloc_config.tracing) {
+        tracemalloc_remove_trace_unlocked(domain, ptr);
+        result = 0;
+    }
+    else {
         /* tracemalloc is not tracing: do nothing */
-        return -2;
+        result = -2;
     }
-    tracemalloc_remove_trace_unlocked(domain, ptr);
+
     TABLES_UNLOCK();
-    return 0;
+    return result;
 }