Skip to content

Commit 1076f10

Browse files
committed
--disable-gil doesn't support --enable-experimental-jit
1 parent 22f0730 commit 1076f10

File tree

3 files changed

+19
-0
lines changed

3 files changed

+19
-0
lines changed

PCbuild/build.bat

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,13 @@ if "%do_pgo%" EQU "true" if "%platf%" EQU "x64" (
123123
)
124124
)
125125

126+
if "%UseDisableGil%" EQU "true" if "%UseTIER2%" NEQ "" (
127+
rem GH-133171: This configuration builds the JIT but never actually uses it,
128+
rem which is surprising (and strictly worse than not building it at all):
129+
echo.ERROR: --experimental-jit cannot be used with --disable-gil.
130+
exit /b 1
131+
)
132+
126133
if not exist "%GIT%" where git > "%TEMP%\git.loc" 2> nul && set /P GIT= < "%TEMP%\git.loc" & del "%TEMP%\git.loc"
127134
if exist "%GIT%" set GITProperty=/p:GIT="%GIT%"
128135
if not exist "%GIT%" echo Cannot find Git on PATH & set GITProperty=

configure

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

configure.ac

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1837,6 +1837,12 @@ AC_SUBST([REGEN_JIT_COMMAND])
18371837
AC_SUBST([JIT_STENCILS_H])
18381838
AC_MSG_RESULT([$tier2_flags $jit_flags])
18391839

1840+
if test "$disable_gil" = "yes" -a "$enable_experimental_jit" != "no"; then
1841+
# GH-133171: This configuration builds the JIT but never actually uses it,
1842+
# which is surprising (and strictly worse than not building it at all):
1843+
AC_MSG_ERROR([--enable-experimental-jit cannot be used with --disable-gil.])
1844+
fi
1845+
18401846
# Enable optimization flags
18411847
AC_SUBST([DEF_MAKE_ALL_RULE])
18421848
AC_SUBST([DEF_MAKE_RULE])

0 commit comments

Comments
 (0)